Update application CRD types, implement application manager draft #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varsharaju
pushed a commit
to varsharaju/argo-cd
that referenced
this pull request
Jun 14, 2018
Add ref cleanup for swagger combined
jannfis
referenced
this pull request
in jannfis/argo-cd
Mar 22, 2020
# This is the 1st commit message: Containerize tests - test cycle # This is the commit message #2: adapt working directory # This is the commit message #3: Build before running tests (so we might have a cache) # This is the commit message #4: Test limiting parallelism # This is the commit message #5: Remove unbound variable # This is the commit message #6: Decrease parallelism to find out limit # This is the commit message #7: Use correct flag # This is the commit message #8: Update Docker image # This is the commit message #9: Remove build phase and increase parallelism # This is the commit message #10: Further increase parallelism
jannfis
added a commit
that referenced
this pull request
Jun 22, 2020
* Add initial primitives and tests for GPG related operations * More tests and test documentation * Move gpg primitives to own module * Add initial primitives for running git verify-commit and tests * Improve and better comment test * Implement VerifyCommitSignature() primitive for metrics wrapper * More commentary * Make reposerver verify gpg signatures when generating manifests * Make signature validation optional * Forbid use of local manifests when signature verification is enabled * Introduce new signatureKeys field in project CRD * Initial support for only syncing against signed revisions * Updates to GnuPG primitives and more test cases * Move signature verification to correct place and add tests * Add signature verification result to revision metadata and display it in UI * Add more primitives and move out some stuff to common module * Add more testdata * Add key management primitives to ArgoDB * Move type GnuPGPublicKey to appsv1 package * Add const ArgoCDGPGKeysConfigMapName * Handle key operations with appsv1.GnuPGPublicKey * Add initial API for managing GPG keys * Remove deprecated code * Add primitives for adding public keys to configuration * Change semantics of ValidateGPGKeys to return more key information * Add key import functionality to public key API * Fix code quirks reported by linter * More code quirks fixes * Fix test * Add primitives for deleting keys from configuration * Add delete key operation to API and CLI * Cosmetics * Implement logic to sync configuration to keyring in repo-server * Add IsGPGEnabled() primitive and also update trustdb on ownertrust changes * Use gpg.IsGPGEnabled() instead of custom test * Remove all keyring manipulating methods from DB * Cosmetics/comments * Require grpc methods from argoproj pkg * Enable setting config path via ARGOCD_GPG_DATA_PATH * Allow "no" and any cases in ARGOCD_GPG_ENABLED * Enable GPG feature on start and start-e2e and set required environment * Cosmetics/comments * Cosmetics and commentary * Update API documentation * Fix comment * Only run GPG related operations if GPG is enabled * Allow setting ARGOCD_GPG_ENABLE from the environment * Create GPG ConfigMap resource during installation * Use function instead of constant to get the watcher path * Re-watch source path in case it gets recreated. Also, error on finish * Add End-to-End tests for GPG commit verification * Introduce SignatureKey type for AppProject CRD * Fix merge error from previous commit * Adapt test for additional manifest (argocd-gpg-keys-cm.yaml) * Fix linter issues * Adapt CircleCI configuration to enable running tests * Add wrapper scripts for git and gpg * Sigh. * Display gpg version in CircleCI * Install gnupg2 and link it to gpg in CI * Try to install gnupg2 in CircleCI image * More CircleCI tweaks * # This is a combination of 10 commits. # This is the 1st commit message: Containerize tests - test cycle # This is the commit message #2: adapt working directory # This is the commit message #3: Build before running tests (so we might have a cache) # This is the commit message #4: Test limiting parallelism # This is the commit message #5: Remove unbound variable # This is the commit message #6: Decrease parallelism to find out limit # This is the commit message #7: Use correct flag # This is the commit message #8: Update Docker image # This is the commit message #9: Remove build phase and increase parallelism # This is the commit message #10: Further increase parallelism * Dockerize toolchain * Add new targets to Makefile * Codegen * Properly handle permissions for E2E tests * Remove gnupg2 installation from CircleCI configuration * Limit parallelism of build * Fix Yarn lint * Retrigger CI for possible flaky test * Codegen * Remove duplicate target in Makefile * Pull in pager from dep ensure -v * Adapt to gitops-engine changes and codegen * Use new health package for health status constants * Add GPG methods to ArgoDB mock module * Fix possible nil pointer dereference * Fix linter issue in imports * Introduce RBAC resource type 'gpgkeys' and adapt policies * Use ARGOCD_GNUPGHOME instead of GNUPGHOME for subsystem configuration Also remove some deprecated unit tests. * Also register GPG keys API with gRPC-GW * Update from codegen * Update GPG key API * Add web UI to manage GPG keys * Lint updates * Change wording * Add some plausibility checks for supplied data on key creation * Update from codegen * Re-allow binary keys and move check for ASCII armoured to UI * Make yarn lint happy * Add editing signature keys for projects in UI * Add ability to configure signature keys for project in CLI * Change default value to use for GNUPGHOME * Do not include data section in default gpg keys CM * Adapt Docker image for GnuPG feature * Add required configuration to installation manifests * Add add-signature-key and remove-signature-key commands to project CLI * Fix typo * Add initial user documentation for GnuPG verification * Fix role name - oops * Mention required RBAC roles in docs * Support GPG verification of git annotated tags as well * Ensure CLI can build succesfully * Better support verification on tags * Print key type in upper case * Update user documentation * Correctly disable GnuPG verification if ARGOCD_GPG_ENABLE=false * Clarify that this feature is only available with Git repositories * codegen * Move verification code to own function * Remove deprecated check * Make things more developer friendly when running locally * Enable GPG feature by default, and don't require ARGOCD_GNUPGHOME to be set * Revert changes to manifests to reflect default enable state * Codegen
alexmt
pushed a commit
that referenced
this pull request
Jan 27, 2021
improve diffArrayCached and address review comments
plakyda-codefresh
referenced
this pull request
in plakyda-codefresh/argo-cd
Sep 20, 2021
Feat retry app creation
3 tasks
mteodor
pushed a commit
to mteodor/argo-cd
that referenced
this pull request
Oct 12, 2022
* Documentation for argo-cd upgrades * Merge pull request argoproj#12 from wings-software/conn-type [CDS-33491]: Add ConectionType enum to clusters and repos * Connection Type for repos and clusters * feat: [CDS-37954]: Returning the entire RepoCreds object instead of only the URL (argoproj#14) * remove repo.appDetails breaking line * Merge pull request argoproj#2 from wings-software/GIT-265 Mask repository secrets instead of exposing them in order to tell the… * Merge pull request argoproj#3 from wings-software/GIT-260 deprecate updateFields and use google.protobuf.FieldMask updateMask i… * Merge pull request argoproj#8 from wings-software/GIT-436 Git 436 * Merge pull request argoproj#10 from wings-software/GIT-436 [GIT-436]: Fixed mask not being able to overwrite with zero-value * clean up * harness-gen * update generate file * fix imports * lint fix * update doc * update versions * include versions in maifest * update manifests * adjust proto num
14 tasks
raghavi101
pushed a commit
to raghavi101/argo-cd
that referenced
this pull request
Feb 20, 2024
…ds (argoproj#3) * Add new project default destination service account commands Signed-off-by: ishitasequeira <[email protected]> * Add generated docs Signed-off-by: ishitasequeira <[email protected]> * remove name from application destination service accounts Signed-off-by: ishitasequeira <[email protected]> * Add validations on commands and address comments Signed-off-by: ishitasequeira <[email protected]> * Add destination service accounts to project list commands Signed-off-by: ishitasequeira <[email protected]> * Add example to the command Signed-off-by: ishitasequeira <[email protected]> --------- Signed-off-by: ishitasequeira <[email protected]>
3 tasks
raghavi101
pushed a commit
to raghavi101/argo-cd
that referenced
this pull request
Mar 6, 2024
…ds (argoproj#3) * Add new project default destination service account commands Signed-off-by: ishitasequeira <[email protected]> * Add generated docs Signed-off-by: ishitasequeira <[email protected]> * remove name from application destination service accounts Signed-off-by: ishitasequeira <[email protected]> * Add validations on commands and address comments Signed-off-by: ishitasequeira <[email protected]> * Add destination service accounts to project list commands Signed-off-by: ishitasequeira <[email protected]> * Add example to the command Signed-off-by: ishitasequeira <[email protected]> --------- Signed-off-by: ishitasequeira <[email protected]>
Mangaal
pushed a commit
to Mangaal/argo-cd
that referenced
this pull request
Apr 11, 2024
…ds (argoproj#3) * Add new project default destination service account commands Signed-off-by: ishitasequeira <[email protected]> * Add generated docs Signed-off-by: ishitasequeira <[email protected]> * remove name from application destination service accounts Signed-off-by: ishitasequeira <[email protected]> * Add validations on commands and address comments Signed-off-by: ishitasequeira <[email protected]> * Add destination service accounts to project list commands Signed-off-by: ishitasequeira <[email protected]> * Add example to the command Signed-off-by: ishitasequeira <[email protected]> --------- Signed-off-by: ishitasequeira <[email protected]> Signed-off-by: anandf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.