-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Including namespace whiteliste resources support #3292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great progress @rachelwang20 !
Added a couple of minor comments.
Run make codegen
to regenerate CRD definition and related go code.
Please document new field in the following files:
Codecov Report
@@ Coverage Diff @@
## master #3292 +/- ##
==========================================
- Coverage 39.05% 39.03% -0.03%
==========================================
Files 48 173 +125
Lines 1398 18811 +17413
Branches 272 272
==========================================
+ Hits 546 7343 +6797
- Misses 845 10548 +9703
- Partials 7 920 +913
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @rachelwang20 !
Checklist:
Issue link: #2900