Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: global project #4506

Merged
merged 16 commits into from
Oct 13, 2020
Merged

Conversation

mayzhang2000
Copy link
Contributor

@mayzhang2000 mayzhang2000 commented Oct 8, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I've signed the CLA and my build is green (troubleshooting builds).

fixes: #4416

@codecov-io
Copy link

codecov-io commented Oct 8, 2020

Codecov Report

Merging #4506 into master will increase coverage by 0.01%.
The diff coverage is 23.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4506      +/-   ##
==========================================
+ Coverage   41.29%   41.30%   +0.01%     
==========================================
  Files         122      123       +1     
  Lines       16608    16800     +192     
==========================================
+ Hits         6858     6940      +82     
- Misses       8760     8860     +100     
- Partials      990     1000      +10     
Impacted Files Coverage Δ
util/settings/settings.go 40.42% <0.00%> (-0.68%) ⬇️
util/argo/argo.go 65.01% <14.70%> (-7.59%) ⬇️
controller/appcontroller.go 49.77% <100.00%> (-1.09%) ⬇️
controller/sync.go 70.37% <100.00%> (ø)
server/application/application.go 29.10% <100.00%> (+0.07%) ⬆️
server/server.go 54.83% <100.00%> (-0.13%) ⬇️
controller/clusterinfoupdater.go 35.08% <0.00%> (-4.92%) ⬇️
reposerver/cache/cache.go 90.32% <0.00%> (-3.02%) ⬇️
util/db/cluster.go 62.30% <0.00%> (-1.79%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8995d04...d958d64. Read the comment docs.

@jessesuen jessesuen requested a review from alexmt October 8, 2020 21:14
util/argo/argo.go Show resolved Hide resolved
util/argo/argo.go Outdated Show resolved Hide resolved
@mayzhang2000 mayzhang2000 marked this pull request as ready for review October 9, 2020 23:47
util/argo/argo.go Outdated Show resolved Hide resolved
util/settings/settings.go Outdated Show resolved Hide resolved
util/argo/argo.go Outdated Show resolved Hide resolved
util/argo/argo.go Outdated Show resolved Hide resolved
util/argo/argo.go Outdated Show resolved Hide resolved
util/argo/argo.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mayzhang2000 mayzhang2000 merged commit f512d21 into argoproj:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global (inherited) project settings
4 participants