overrideNamespace is not propagated to redis-secret

[nikolaof]

Describe the bug

When creating an umbrella (wrapper) helm chart to deploy argocd and use the overrideNamespace attribute in values the redis-secret is created to the default namespace and not in the defined one. This makes all pods except the applicationset one unable to start. They return an error redis-secret not found

Related helm chart

argo-cd

Helm chart version

7.3.4

To Reproduce

Create an umbrella chart like this

Chart.yaml

apiVersion: v2
name: argo-cd
version: 1.0.2
dependencies:
  - name: argo-cd
    version: 7.3.4
    repository: https://argoproj.github.io/argo-helm

values.yaml

argo-cd:
  namespaceOverride: argo-cd
  dex:
    enabled: false
  notifications:
    enabled: false
  applicationSet:
    enabled: false
  server:
    extraArgs:
      - --insecure

Expected behavior

To create the redis-secret in the defined namespace, so the pods can access it.

Screenshots

No response

Additional context

What I did was to change locally the following lines:

argo-helm/charts/argo-cd/templates/redis-secret-init/job.yaml

Line 6 in 6dab549

namespace: {{ .Release.Namespace | quote }}

argo-helm/charts/argo-cd/templates/redis-secret-init/role.yaml

Line 11 in 6dab549

namespace: {{ .Release.Namespace | quote }}

argo-helm/charts/argo-cd/templates/redis-secret-init/rolebinding.yaml

Line 11 in 6dab549

namespace: {{ .Release.Namespace | quote }}

argo-helm/charts/argo-cd/templates/redis-secret-init/serviceaccount.yaml

Line 7 in 6dab549

namespace: {{ .Release.Namespace | quote }}

and replace them with the following:

namespace: {{ include  "argo-cd.namespace" . }}

Then I used this modified version of argo-cd chart to build my umbrella chart and everything was deployed correctly without errors.

Shall I create a PR to commit these changes or it is not the proper way to do it?

[mkilchhofer]

Hi @nikolaof

Thanks for reporting that 👍 .
I created a PR to address that issue:

• fix(argo-cd): Address oversights of feature namespaceOverride #2821