Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(argo-cd): Address oversights of feature namespaceOverride #2821

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix(argo-cd): Address oversights of feature namespaceOverride #2821

merged 1 commit into from
Jul 10, 2024

Conversation

mkilchhofer
Copy link
Member

@mkilchhofer mkilchhofer commented Jul 10, 2024 •
edited
Loading

Fixes #2817

This is a regression of:

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@mkilchhofer mkilchhofer force-pushed the bugix/argo-cd_namespaceOverride branch from cb623a1 to f528bf2 Compare July 10, 2024 13:03
@mkilchhofer mkilchhofer mentioned this pull request Jul 10, 2024
Closed
@mbevc1 mbevc1 merged commit 79e3242 into main Jul 10, 2024
8 checks passed
@mbevc1 mbevc1 deleted the bugix/argo-cd_namespaceOverride branch July 10, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbevc1 mbevc1 mbevc1 approved these changes

@yu-croco yu-croco yu-croco approved these changes

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@pdrastil pdrastil Awaiting requested review from pdrastil pdrastil is a code owner

@tico24 tico24 Awaiting requested review from tico24 tico24 is a code owner

Assignees
No one assigned
Labels
argo-cd size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

overrideNamespace is not propagated to redis-secret
3 participants
@mkilchhofer @mbevc1 @yu-croco