feat(argo-cd): Upgrade Argo CD to 2.6.0 #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdrastil
added
awaiting-upstream
Lobstrosity
reviewed
Jan 11, 2023
pdrastil
force-pushed
the
feature/upgrade
branch
from
9f470f0
to
f8130e1
Compare
pdrastil
force-pushed
the
feature/upgrade
branch
2 times, most recently
from
3fc61e7
to
fa2f120
Compare
pdrastil
force-pushed
the
feature/upgrade
branch
9 times, most recently
from
909d7bf
to
1b55fac
Compare
pdrastil
force-pushed
the
feature/upgrade
branch
6 times, most recently
from
b6326d1
to
bf46e1e
Compare
pdrastil
force-pushed
the
feature/upgrade
branch
3 times, most recently
from
32c5afd
to
cc41f6a
Compare
pdrastil
requested review from
mr-sour,
yann-soubeyrand,
mbevc1,
mkilchhofer,
yu-croco and
jmeridth
as code owners
Signed-off-by: Petr Drastil <[email protected]>
pdrastil
force-pushed
the
feature/upgrade
branch
from
cc41f6a
to
61eb7e7
Compare
|
Hey everyone, any updates on when this will be released? |
pdrastil
removed
the
awaiting-upstream
|
@mbastawisy-careem once we get another approval. Thank you for your patience. |
eliihen
reviewed
Feb 7, 2023
| type: object | ||
| required: | ||
| - metadata | ||
| - spec | ||
| type: object | ||
| required: | ||
| - pathParamPrefix |
There was a problem hiding this comment.
Is it intentional that this is required now? I'm getting the following error when upgrading:
failed to apply ApplicationSet.argoproj.io, argocd/skip-apps: ApplicationSet.argoproj.io "skip-apps" is invalid: spec.generators[0].git. pathParamPrefix: Required value
The documentation seems to infer that it should be optional:
https://argo-cd.readthedocs.io/en/release-2.6/operator-manual/applicationset/Generators-Git/#git-generator-directories
There was a problem hiding this comment.
Good catch @esphen - missed that one with diff. PR contains the fix #1829
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to 2.6.0 stable version
Upgrade notes: https://argo-cd.readthedocs.io/en/latest/operator-manual/upgrading/2.5-2.6/
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Changes are automatically published when merged to
main. They are not published on branches.