feat(argo-workflows): Updated supported workers parameters #2297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeniy-khatko
requested review from
vladlosev,
jmeridth,
yu-croco and
tico24
as code owners
jmeridth
approved these changes
Oct 16, 2023
yu-croco
requested changes
Oct 16, 2023
evgeniy-khatko
force-pushed
the
main
branch
2 times, most recently
from
a6ac98b
to
07b915a
Compare
added 2 commits
October 23, 2023 18:56
Change ------ Based on argo-workflows [scaling documents](https://argoproj.github.io/argo-workflows/scaling/) it's possible to set following workers values: `--workflow-workers`, `--workflow-ttl-workers`, `--pod-cleanup-workers` and statring 3.5 `--cron-workflow-workers`. This change allows chart consumers to take advatage of _all_ these parameters. Testing ------- ``` helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep workers helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers - "--workflow-workers" - "10" helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers - "--workflow-workers" - "10" - "--workflow-ttl-workers" - "20" helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers - "--workflow-workers" - "10" - "--workflow-ttl-workers" - "20" - "--pod-cleanup-workers" - "30" helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers - "--workflow-workers" - "10" - "--workflow-ttl-workers" - "20" - "--pod-cleanup-workers" - "30" - "--cron-workflow-workers" - "40" ``` Signed-off-by: Evgeny Khatko <[email protected]> Signed-off-by: Evgeny Khatko <[email protected]>
Signed-off-by: Evgeny Khatko <[email protected]>
yu-croco
previously approved these changes
Oct 24, 2023
Signed-off-by: Tim Collins <[email protected]>
Signed-off-by: Tim Collins <[email protected]>
yu-croco
reviewed
Oct 24, 2023
Signed-off-by: Tim Collins <[email protected]>
|
Thanks @tico24 |
|
Ah I think version is supposed to be |
|
man I'm good at this! |
Signed-off-by: Tim Collins <[email protected]>
yu-croco
approved these changes
Oct 24, 2023
tico24
approved these changes
Oct 24, 2023
Kripu77
pushed a commit
to Kripu77/argo-helm
that referenced
this pull request
Nov 16, 2023
…2297) * feat(argo-workflows): Updated supported workers parameters Change ------ Based on argo-workflows [scaling documents](https://argoproj.github.io/argo-workflows/scaling/) it's possible to set following workers values: `--workflow-workers`, `--workflow-ttl-workers`, `--pod-cleanup-workers` and statring 3.5 `--cron-workflow-workers`. This change allows chart consumers to take advatage of _all_ these parameters. Testing ------- ``` helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep workers helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers - "--workflow-workers" - "10" helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers - "--workflow-workers" - "10" - "--workflow-ttl-workers" - "20" helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers - "--workflow-workers" - "10" - "--workflow-ttl-workers" - "20" - "--pod-cleanup-workers" - "30" helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers - "--workflow-workers" - "10" - "--workflow-ttl-workers" - "20" - "--pod-cleanup-workers" - "30" - "--cron-workflow-workers" - "40" ``` Signed-off-by: Evgeny Khatko <[email protected]> Signed-off-by: Evgeny Khatko <[email protected]> * Addressing PR feedback. Signed-off-by: Evgeny Khatko <[email protected]> * newline Signed-off-by: Tim Collins <[email protected]> * Update Chart.yaml Signed-off-by: Tim Collins <[email protected]> * Update Chart.yaml Signed-off-by: Tim Collins <[email protected]> --------- Signed-off-by: Evgeny Khatko <[email protected]> Signed-off-by: Evgeny Khatko <[email protected]> Signed-off-by: Tim Collins <[email protected]> Co-authored-by: Evgeny Khatko <[email protected]> Co-authored-by: Tim Collins <[email protected]> Signed-off-by: Kripu Khadka <[email protected]>
Kripu77
pushed a commit
to Kripu77/argo-helm
that referenced
this pull request
Nov 16, 2023
…2297) * feat(argo-workflows): Updated supported workers parameters Change ------ Based on argo-workflows [scaling documents](https://argoproj.github.io/argo-workflows/scaling/) it's possible to set following workers values: `--workflow-workers`, `--workflow-ttl-workers`, `--pod-cleanup-workers` and statring 3.5 `--cron-workflow-workers`. This change allows chart consumers to take advatage of _all_ these parameters. Testing ------- ``` helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep workers helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers - "--workflow-workers" - "10" helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers - "--workflow-workers" - "10" - "--workflow-ttl-workers" - "20" helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers - "--workflow-workers" - "10" - "--workflow-ttl-workers" - "20" - "--pod-cleanup-workers" - "30" helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers - "--workflow-workers" - "10" - "--workflow-ttl-workers" - "20" - "--pod-cleanup-workers" - "30" - "--cron-workflow-workers" - "40" ``` Signed-off-by: Evgeny Khatko <[email protected]> Signed-off-by: Evgeny Khatko <[email protected]> * Addressing PR feedback. Signed-off-by: Evgeny Khatko <[email protected]> * newline Signed-off-by: Tim Collins <[email protected]> * Update Chart.yaml Signed-off-by: Tim Collins <[email protected]> * Update Chart.yaml Signed-off-by: Tim Collins <[email protected]> --------- Signed-off-by: Evgeny Khatko <[email protected]> Signed-off-by: Evgeny Khatko <[email protected]> Signed-off-by: Tim Collins <[email protected]> Co-authored-by: Evgeny Khatko <[email protected]> Co-authored-by: Tim Collins <[email protected]> Signed-off-by: Kripu Khadka <[email protected]>
yaroslav-codefresh
added a commit
to codefresh-io/argo-helm
that referenced
this pull request
Dec 7, 2023
* chore(argo-workflows): Upgrade to Argo Workflows v3.4.10 (argoproj#2220) * feat(argo-workflows): add imagePullSecret for workflow sa (argoproj#2226) Signed-off-by: Fuochi <[email protected]> * chore(argo-workflows): update comment for azure artifact repository blobNameFormat (argoproj#2229) * chore(argo-cd): Upgrade Argo CD to v2.8.1 (argoproj#2230) Signed-off-by: yu-croco <[email protected]> * chore(argo-cd): Upgrade Argo CD to v2.8.2 (argoproj#2231) Signed-off-by: yu-croco <[email protected]> * fix(argo-cd): Fix applicationSet HA examples in README.md (argoproj#2232) Signed-off-by: Joonas Venäläinen <[email protected]> * chore(deps): bump actions/checkout from 3.5.3 to 3.6.0 (argoproj#2234) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.3 to 3.6.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@c85c95e...f43a0e5) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(argo-cd): Upgrade redis-exporter to 1.53.0 (argoproj#2236) Signed-off-by: Petr Drastil <[email protected]> Co-authored-by: Aikawa <[email protected]> * chore(argo-cd): Remove support for legacy cert-manager APIs (argoproj#2238) * chore(argo-cd): Remove support for legacy cert-manager APIs Signed-off-by: Petr Drastil <[email protected]> * Bump minor version Signed-off-by: Petr Drastil <[email protected]> --------- Signed-off-by: Petr Drastil <[email protected]> * chore(argo-cd): Remove support for autoscaling/v1 (argoproj#2237) Signed-off-by: Petr Drastil <[email protected]> * chore(argo-events): Upgrade argo-events to 1.8.1 (argoproj#2247) https://github.com/argoproj/argo-events/releases/tag/v1.8.1 Signed-off-by: jmeridth <[email protected]> * fix(argo-cd): Update values.yaml - update custom css styles side bar example (argoproj#2245) * Update values.yaml - update custom css styles side barexample .nav-bar is no longer the css class name Signed-off-by: JesseBot <[email protected]> * Update Chart.yaml - update patch version for values.yaml comment update Signed-off-by: JesseBot <[email protected]> * Update Chart.yaml - update change log Signed-off-by: JesseBot <[email protected]> --------- Signed-off-by: JesseBot <[email protected]> * chore(argo-rollouts): Upgrade Argo Rollouts to v1.6.0 (argoproj#2252) * chore(argo-rollouts): Upgrade Argo Rollouts to v1.6.0 Signed-off-by: Gustav Kofoed Clausen <[email protected]> * chore(argo-rollouts): Update CRDs to matching version Signed-off-by: Gustav Kofoed Clausen <[email protected]> --------- Signed-off-by: Gustav Kofoed Clausen <[email protected]> Co-authored-by: Gustav Kofoed Clausen <[email protected]> * fix(argo-cd): Make the PathType configurable when using single ingress resource in AWS (argoproj#2251) * Make the PathType configurable when using single ingress resource in AWS Signed-off-by: Tamas <[email protected]> * update chart version and doc Signed-off-by: Tamas <[email protected]> * Fix reference to value in range Signed-off-by: Tamas <[email protected]> --------- Signed-off-by: Tamas <[email protected]> Co-authored-by: Tamas <[email protected]> * chore(argo-cd): Upgrade Argo CD to v2.8.3 (argoproj#2254) Signed-off-by: Alexej Disterhoft <[email protected]> * chore(argo-workflows): Upgrade Argo Workflows to v3.4.11 (argoproj#2255) * fix(argo-cd): Restart Repo Server and Application Controller as following the change of Argo CD CM (argoproj#2235) * fix(argo-cd): Restart Repo Server and Application Controller as following the change of Argo CD CM Signed-off-by: yu-croco <[email protected]> * fix(argo-cd): Aligne condition to argocd-cm Signed-off-by: yu-croco <[email protected]> --------- Signed-off-by: yu-croco <[email protected]> * docs(argo-cd): Document scheduling parameters for redis-ha (argoproj#2253) Signed-off-by: Petr Drastil <[email protected]> * feat(argo-cd): adds toggle for helm-working-dir (argoproj#2249) - Adds a toggle to be able to turn off the helm-working-dir for the repo server deployment. Using a shared helm repo storage directory can cause issues when multiple helm commands are being run in parallel. The repo server also has the ability to rebuild the repos and do updates in the normal flow for checking the status of an application so it won't cause issues if it's disabled. Signed-off-by: Andrew Hamilton <[email protected]> * chore(deps): bump actions/checkout from 3.6.0 to 4.0.0 (argoproj#2258) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.6.0 to 4.0.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@f43a0e5...3df4ab1) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump actions/upload-artifact from 3.1.2 to 3.1.3 (argoproj#2259) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.2 to 3.1.3. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@0b7f8ab...a8a3f3a) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aikawa <[email protected]> * docs(argo-workflows): add an HA section (argoproj#2183) * feat(argo-workflows): add a sample HA config - a `values-ha.yaml` as an example for how one would set-up HA according to the Argo Workflows docs Signed-off-by: Anton Gilgur <[email protected]> * docs(argo-workflows): add an HA section - plus add a test for HA, which the docs link to as an example - link back to [upstream docs](https://argoproj.github.io/argo-workflows/high-availability/) as well - follow the same basic structure as the [Argo CD chart for HA](https://github.com/argoproj/argo-helm/blob/3e35b0c7f7d758d553b17f369cc5940484ef5d89/charts/argo-cd/README.md?plain=1#L17) - as asked in review Signed-off-by: Anton Gilgur <[email protected]> --------- Signed-off-by: Anton Gilgur <[email protected]> Signed-off-by: Anton Gilgur <[email protected]> Co-authored-by: Aikawa <[email protected]> * fix(argo-cd): Migrate leftover of applicationSet.replicaCount to applicationSet.replicas (argoproj#2261) Signed-off-by: yu-croco <[email protected]> * docs(argo-cd): improve changelog (argoproj#2262) * clarify 5.19.0 changes * revise wording Signed-off-by: Josh Soref <[email protected]> * fix(github): Fix changelog spelling of versions (argoproj#2263) Signed-off-by: Josh Soref <[email protected]> Co-authored-by: Aikawa <[email protected]> * chore(argo-cd): Upgrade Argo CD to v2.8.4 (argoproj#2268) * fix(argo-cd): Align redis-ha's affinity type to upstream due to warnings (argoproj#2270) Signed-off-by: yu-croco <[email protected]> * chore(deps): bump docker/login-action from 2.2.0 to 3.0.0 (argoproj#2271) * fix(argo-cd): make ServiceMonitor annotations in ArgoCD server conditional (argoproj#2273) * fix: add argocd servicemonitor annotations conditionally Signed-off-by: Mats Willemsen <[email protected]> * chore(argo-cd): add changelog Signed-off-by: Mats Willemsen <[email protected]> --------- Signed-off-by: Mats Willemsen <[email protected]> * fix(argo-cd): Add checksum for CMP ConfigMap in repo-server Pod annotations (argoproj#2275) Add checksum for CMP ConfigMap in repo-server This helm chart defines the plugins as ConfigMaps -- according to the docs, when the CM is modified, the repo-server Pod must be restarted to have the sidecars pick up the latest changes: https://argo-cd.readthedocs.io/en/stable/operator-manual/config-management-plugins/#debugging-a-cmp The changes in this helm chart allow for a checksum to be calculated from the ConfigMap and added as a Pod annotation so whenever the CM values are modified, the Pod is restarted automatically. Signed-off-by: sibucan <[email protected]> * fix(argo-cd): Redis to 7.0.13 to fix CVE-2022-48174 (argoproj#2279) * Redis to 7.0.13 Signed-off-by: Pieter van der Giessen <[email protected]> * changelog Signed-off-by: Pieter van der Giessen <[email protected]> --------- Signed-off-by: Pieter van der Giessen <[email protected]> * chore(deps): bump actions/checkout from 4.0.0 to 4.1.0 (argoproj#2280) Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@3df4ab1...8ade135) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump amannn/action-semantic-pull-request from 5.2.0 to 5.3.0 (argoproj#2284) * chore(deps): bump ossf/scorecard-action from 2.2.0 to 2.3.0 (argoproj#2290) * chore(deps): bump actions/setup-python from 4.7.0 to 4.7.1 (argoproj#2289) * fix(argo-cd): Sync redis / redis-ha readOnlyRootFilesystem from upstream (argoproj#2294) Signed-off-by: Marco Maurer <[email protected]> * feat(argo-workflows): Configure declarative server auth mode (argoproj#2291) * chore(argo-workflows): Upgrade argo-workflows to 3.5.0 (argoproj#2228) Diff based on the rc1 branch currently here [3.4.10...3.5.0](argoproj/argo-workflows@v3.4.10...v3.5.0) Signed-off-by: jmeridth <[email protected]> * feat(argo-workflows): Added commonLabels (argoproj#2300) * fix(argo-workflows): add all crds to aggregate-roles template (argoproj#2301) fix: add all crds to aggregate-roles Signed-off-by: Jonathan Raymond <[email protected]> * chore(deps): bump actions/checkout from 4.1.0 to 4.1.1 (argoproj#2304) * chore(argo-workflows): Add sample of PostgreSQL ssl entries in values.yaml (argoproj#2307) Signed-off-by: yu-croco <[email protected]> * feat(argo-workflows): Updated supported workers parameters (argoproj#2297) * feat(argo-workflows): Updated supported workers parameters Change ------ Based on argo-workflows [scaling documents](https://argoproj.github.io/argo-workflows/scaling/) it's possible to set following workers values: `--workflow-workers`, `--workflow-ttl-workers`, `--pod-cleanup-workers` and statring 3.5 `--cron-workflow-workers`. This change allows chart consumers to take advatage of _all_ these parameters. Testing ------- ``` helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep workers helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers - "--workflow-workers" - "10" helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers - "--workflow-workers" - "10" - "--workflow-ttl-workers" - "20" helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers - "--workflow-workers" - "10" - "--workflow-ttl-workers" - "20" - "--pod-cleanup-workers" - "30" helm upgrade argowf charts/argo-workflows -n argo --values charts/argo-workflows/values.yaml --create-namespace --debug | grep -A70 "Source: argo-workflows/templates/controller/workflow-controller-deployment.yaml" | grep -A1 workers - "--workflow-workers" - "10" - "--workflow-ttl-workers" - "20" - "--pod-cleanup-workers" - "30" - "--cron-workflow-workers" - "40" ``` Signed-off-by: Evgeny Khatko <[email protected]> Signed-off-by: Evgeny Khatko <[email protected]> * Addressing PR feedback. Signed-off-by: Evgeny Khatko <[email protected]> * newline Signed-off-by: Tim Collins <[email protected]> * Update Chart.yaml Signed-off-by: Tim Collins <[email protected]> * Update Chart.yaml Signed-off-by: Tim Collins <[email protected]> --------- Signed-off-by: Evgeny Khatko <[email protected]> Signed-off-by: Evgeny Khatko <[email protected]> Signed-off-by: Tim Collins <[email protected]> Co-authored-by: Evgeny Khatko <[email protected]> Co-authored-by: Tim Collins <[email protected]> * fix(argo-rollouts): controller replicas count comparison (argoproj#2309) * feat(argo-cd): add terminationGracePeriodSeconds (argoproj#2310) Signed-off-by: toyamagu-2021 <[email protected]> * chore(argo-cd): Upgrade Argo CD to v2.8.5 (argoproj#2313) * chore(deps): bump ossf/scorecard-action from 2.3.0 to 2.3.1 (argoproj#2314) * fix(argo-cd): Update Bitbucket SSH key (argoproj#2317) Signed-off-by: Petr Drastil <[email protected]> * feat(argo-cd): add notification cluster role (argoproj#2315) * Add notification cluster role Signed-off-by: drfaust92 <[email protected]> * Add notification cluster role Signed-off-by: drfaust92 <[email protected]> * Add notification cluster role Signed-off-by: drfaust92 <[email protected]> * Add notification cluster role Signed-off-by: drfaust92 <[email protected]> --------- Signed-off-by: drfaust92 <[email protected]> * fix(argo-rollouts): Update AnalysisRun CRD to match upstream (argoproj#2320) * fix(github): update chart testing action due to failure (argoproj#2324) Getting failure when running chart testing action pulling v2.0.0 from sigstore Updating action to see if this helps Signed-off-by: jmeridth <[email protected]> * chore(argo-cd): Upgrade Argo CD to v2.8.6 (argoproj#2323) * chore(argo-cd): Upgrade Argo CD to v2.8.6 Signed-off-by: Tim Collins <[email protected]> * fix: drop unrecognized helm timeout Signed-off-by: jmeridth <[email protected]> --------- Signed-off-by: Tim Collins <[email protected]> Signed-off-by: Jason Meridth <[email protected]> Signed-off-by: jmeridth <[email protected]> Co-authored-by: Jason Meridth <[email protected]> * fix(argo-cd): Create notifications clusterrole and clusterrolebinding when enabled (argoproj#2326) * Create clusterrole for nitifications only when notifications enabled Signed-off-by: Denis Kadyshev <[email protected]> * Create clusterrolebinding for nitifications only when notifications enbaled Signed-off-by: Denis Kadyshev <[email protected]> * Bump version in Chart.yaml Signed-off-by: Denis Kadyshev <[email protected]> * Update Chart.yaml Signed-off-by: Denis Kadyshev <[email protected]> * Update Chart.yaml Signed-off-by: Denis Kadyshev <[email protected]> --------- Signed-off-by: Denis Kadyshev <[email protected]> * fix(argo-workflows): Fix outdated URL in values.yaml comments (argoproj#2328) * fix outdated link branch link Branch was renamed prior, redirects to main now Signed-off-by: Max! <[email protected]> * Update Chart.yaml Signed-off-by: Max! <[email protected]> * add to changelog Signed-off-by: Max! <[email protected]> --------- Signed-off-by: Max! <[email protected]> * chore(argo-workflows): Upgrade Argo Workflows to v3.5.1 (argoproj#2329) Signed-off-by: yu-croco <[email protected]> * chore(deps): bump amannn/action-semantic-pull-request from 5.3.0 to 5.4.0 (argoproj#2330) chore(deps): bump amannn/action-semantic-pull-request Bumps [amannn/action-semantic-pull-request](https://github.com/amannn/action-semantic-pull-request) from 5.3.0 to 5.4.0. - [Release notes](https://github.com/amannn/action-semantic-pull-request/releases) - [Changelog](https://github.com/amannn/action-semantic-pull-request/blob/main/CHANGELOG.md) - [Commits](amannn/action-semantic-pull-request@47b15d5...e9fabac) --- updated-dependencies: - dependency-name: amannn/action-semantic-pull-request dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump helm/chart-releaser-action from 1.5.0 to 1.6.0 (argoproj#2331) Bumps [helm/chart-releaser-action](https://github.com/helm/chart-releaser-action) from 1.5.0 to 1.6.0. - [Release notes](https://github.com/helm/chart-releaser-action/releases) - [Commits](helm/chart-releaser-action@be16258...a917fd1) --- updated-dependencies: - dependency-name: helm/chart-releaser-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump helm/chart-testing-action from 2.6.0 to 2.6.1 (argoproj#2332) Bumps [helm/chart-testing-action](https://github.com/helm/chart-testing-action) from 2.6.0 to 2.6.1. - [Release notes](https://github.com/helm/chart-testing-action/releases) - [Commits](helm/chart-testing-action@b43128a...e6669bc) --- updated-dependencies: - dependency-name: helm/chart-testing-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(argo-cd): Upgrade Argo CD to 2.9.0 (argoproj#2318) Signed-off-by: Petr Drastil <[email protected]> * chore(github): Updated security documentation and CLOMonitor exemptions (argoproj#2333) * Updated security documentation and CLOMonitor exemptions Signed-off-by: Eddie Knight <[email protected]> * Added license scanning exepmtion Signed-off-by: Eddie Knight <[email protected]> * Added best practices badge to README Signed-off-by: Eddie Knight <[email protected]> --------- Signed-off-by: Eddie Knight <[email protected]> Co-authored-by: Jason Meridth <[email protected]> * fix(argo-workflows): Accept multi auth mode for server (argoproj#2336) * fix(argo-workflows): Accept multi auth mode for server Signed-off-by: yu-croco <[email protected]> * chore(argo-workflows): improve description of authMode Signed-off-by: yu-croco <[email protected]> * chore(argo-workflows): keep the older value valid for now as compatibility. Signed-off-by: yu-croco <[email protected]> --------- Signed-off-by: yu-croco <[email protected]> * chore(github): Add yu-cruco to * in CODEOWNERS (argoproj#2338) chore: Add yu-cruco to * in CODEOWNERS yu-cruco is now a maintainer and will be notified on all PRs - [x] moved CODEOWNERS into .github folder where it belongs Signed-off-by: jmeridth <[email protected]> * fix(argo-cd): Add permission for Applications in any namespace (argoproj#2341) Signed-off-by: yu-croco <[email protected]> * chore(argo-cd): Upgrade Argo CD to v2.9.1 (argoproj#2344) * chore(argo-rollouts): Bump rollouts to 1.6.1 (argoproj#2345) * Bump rollouts to 1.6.2 Signed-off-by: drfaust92 <[email protected]> * Bump to 1.6.1 Signed-off-by: drfaust92 <[email protected]> * Bump to 1.6.1 Signed-off-by: drfaust92 <[email protected]> --------- Signed-off-by: drfaust92 <[email protected]> Co-authored-by: Aikawa <[email protected]> * chore(argo-rollouts): Bump rollouts to 1.6.2 (argoproj#2347) * fix(argo-workflows): Add parameters for tuning revisionHistoryLimit and emptyDir volumes (argoproj#2346) * fix(argo-workflows): Align version label (argoproj#2342) * fix(argo-workflows): Aligne version label Signed-off-by: yu-croco <[email protected]> * fix(argo-workflows): fix typo Signed-off-by: yu-croco <[email protected]> --------- Signed-off-by: yu-croco <[email protected]> * docs(github): typo fix in security.md (argoproj#2343) * typo fix Signed-off-by: Kripu Khadka <[email protected]> * Revert "typo fix" This reverts commit b02b2fb. Signed-off-by: Kripu Khadka <[email protected]> * typo fix in SECURITY.md Signed-off-by: Kripu Khadka <[email protected]> Signed-off-by: Kripu Khadka <[email protected]> --------- Signed-off-by: Kripu Khadka <[email protected]> Signed-off-by: Kripu Khadka <[email protected]> Co-authored-by: Aikawa <[email protected]> * chore(argo-workflows): Remove xip url from test to avoid confusion (argoproj#2350) * chore(argo-workflows): Remove xip url from test to avoid confusion Signed-off-by: Tim Collins <[email protected]> * Bump version Signed-off-by: Tim Collins <[email protected]> * More bumpings Signed-off-by: Tim Collins <[email protected]> * Tim can't type Signed-off-by: Tim Collins <[email protected]> * Swap to example.com - rfc2606 Signed-off-by: Tim Collins <[email protected]> --------- Signed-off-by: Tim Collins <[email protected]> * chore(argo-cd): Replace non-existing examples with official example domain (argoproj#2352) * chore(argo-cd): Upgrade Argo CD to v2.9.2 (argoproj#2353) Signed-off-by: yu-croco <[email protected]> * chore(github): Update SECURITY-INSIGHTS.yml to include security-contacts (argoproj#2356) * feat(argo-workflows): Make workflow controller ConfigMap optional (argoproj#2354) * chore(argo-workflows): Upgrade Argo Workflows to v3.5.2 (argoproj#2357) Signed-off-by: yu-croco <[email protected]> * fix(argo-rollouts): Update all rollout CRDs to match upstream (argoproj#2361) Signed-off-by: Abdulla Abdurakhmanov <[email protected]> * change image tag * change image tag --------- Signed-off-by: Fuochi <[email protected]> Signed-off-by: yu-croco <[email protected]> Signed-off-by: Joonas Venäläinen <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Petr Drastil <[email protected]> Signed-off-by: jmeridth <[email protected]> Signed-off-by: JesseBot <[email protected]> Signed-off-by: Gustav Kofoed Clausen <[email protected]> Signed-off-by: Tamas <[email protected]> Signed-off-by: Alexej Disterhoft <[email protected]> Signed-off-by: Andrew Hamilton <[email protected]> Signed-off-by: Anton Gilgur <[email protected]> Signed-off-by: Anton Gilgur <[email protected]> Signed-off-by: Josh Soref <[email protected]> Signed-off-by: Mats Willemsen <[email protected]> Signed-off-by: sibucan <[email protected]> Signed-off-by: Pieter van der Giessen <[email protected]> Signed-off-by: Marco Maurer <[email protected]> Signed-off-by: Jonathan Raymond <[email protected]> Signed-off-by: Evgeny Khatko <[email protected]> Signed-off-by: Evgeny Khatko <[email protected]> Signed-off-by: Tim Collins <[email protected]> Signed-off-by: toyamagu-2021 <[email protected]> Signed-off-by: drfaust92 <[email protected]> Signed-off-by: Tim Collins <[email protected]> Signed-off-by: Jason Meridth <[email protected]> Signed-off-by: Denis Kadyshev <[email protected]> Signed-off-by: Max! <[email protected]> Signed-off-by: Eddie Knight <[email protected]> Signed-off-by: Kripu Khadka <[email protected]> Signed-off-by: Kripu Khadka <[email protected]> Signed-off-by: Abdulla Abdurakhmanov <[email protected]> Co-authored-by: Jason Meridth <[email protected]> Co-authored-by: Fuochi <[email protected]> Co-authored-by: Jeongwon Song <[email protected]> Co-authored-by: Aikawa <[email protected]> Co-authored-by: Joonas Venäläinen <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Petr Drastil <[email protected]> Co-authored-by: JesseBot <[email protected]> Co-authored-by: Gustav Kofoed Clausen <[email protected]> Co-authored-by: Gustav Kofoed Clausen <[email protected]> Co-authored-by: Tamas Szasz <[email protected]> Co-authored-by: Tamas <[email protected]> Co-authored-by: Alexej Disterhoft <[email protected]> Co-authored-by: Andrew Hamilton <[email protected]> Co-authored-by: Anton Gilgur <[email protected]> Co-authored-by: Josh Soref <[email protected]> Co-authored-by: Mats Willemsen <[email protected]> Co-authored-by: sibucan <[email protected]> Co-authored-by: Pieter <[email protected]> Co-authored-by: Marco Maurer (-Kilchhofer) <[email protected]> Co-authored-by: Koen van Zuijlen <[email protected]> Co-authored-by: Jonathan Raymond <[email protected]> Co-authored-by: Ujin <[email protected]> Co-authored-by: Evgeny Khatko <[email protected]> Co-authored-by: Tim Collins <[email protected]> Co-authored-by: gussan <[email protected]> Co-authored-by: Ilia Lazebnik <[email protected]> Co-authored-by: Denis Kadyshev <[email protected]> Co-authored-by: Max! <[email protected]> Co-authored-by: Eddie Knight <[email protected]> Co-authored-by: Matt Dainty <[email protected]> Co-authored-by: Kripu Khadka <[email protected]> Co-authored-by: qa-florian-wende <[email protected]> Co-authored-by: Abdulla Abdurakhmanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Based on argo-workflows scaling documents it's possible to set following workers values:
--workflow-workers,--workflow-ttl-workers,--pod-cleanup-workersand statring 3.5--cron-workflow-workers. This change allows chart consumers to take advatage of all these parameters.Testing
Checklist: