Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(argo-workflows): fix wrong artifactRepository identations on values.yaml #2426

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

lucasfcnunes
Copy link
Contributor

@lucasfcnunes lucasfcnunes commented Jan 16, 2024

On artifactRepository.gcs the following 3 keys were in the same level:

  • .serviceAccountKeySecret
  • .name
  • .key

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

on `artifactRepository.gcs`
the following 3 keys were in the same level:
- `.serviceAccountKeySecret`
- `.name`
- `.key`

Signed-off-by: Lucas Fernando Cardoso Nunes <[email protected]>
@lucasfcnunes lucasfcnunes changed the title fix: wrong artifactRepository identations on values.yaml docs(argo-workflows): fix wrong artifactRepository identations on values.yaml Jan 16, 2024
Signed-off-by: Lucas Fernando Cardoso Nunes <[email protected]>
@tico24 tico24 merged commit d5b942a into argoproj:main Jan 17, 2024
6 checks passed
pdrastil added a commit to pdrastil/argo-helm that referenced this pull request Jan 18, 2024
* main:
  feat(argocd-image-updater): Support extra K8s manifests (argoproj#2429)
  docs(argo-workflows): fix wrong `artifactRepository` identations on values.yaml (argoproj#2426)
  docs(argo-cd): Fix policy.csv block (argoproj#2423)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants