Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(argo-cd): Align imagePullSecrets for redis-secret-init Job #2928

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

DoumLaberge
Copy link
Contributor

@DoumLaberge DoumLaberge commented Sep 19, 2024

Correction of the imagepullsecret for redis

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Correction of the imagepullsecret for redis
Copy link
Collaborator

@yu-croco yu-croco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR.
Please fulfill the items in your PR description.

I have bumped the chart version according to versioning
I have updated the documentation according to documentation
I have updated the chart changelog with all the changes that come with this pull request according to changelog.
Any new values are backwards compatible and/or have sensible default.
I have signed off all my commits as required by DCO.
My build is green (troubleshooting builds).

Bump  chart version to 7.5.3
@DoumLaberge DoumLaberge changed the title issue-2848 fix (Argocd) issue-2848 Error in the redis-secret-init/job.yaml for imagepullsecret Sep 19, 2024
@DoumLaberge DoumLaberge changed the title fix (Argocd) issue-2848 Error in the redis-secret-init/job.yaml for imagepullsecret fix(argocd) issue-2848 Error in the redis-secret-init/job.yaml for imagepullsecret Sep 19, 2024
@DoumLaberge
Copy link
Contributor Author

Can someone just include the code in the main branch please. I don't have time to jump in all this hoop. Sorry

@yu-croco yu-croco dismissed their stale review September 19, 2024 14:22

I don't need to be a blocker since all reviewers know the process.

@mmarisetty
Copy link

I hope this one fix this problem ?
Which i'm facing this error:
job argocd-redis-secret-init failed: BackoffLimitExceeded

argoproj/argo-cd#18356

@mmarisetty
Copy link

I hope this one fix this problem ? Which i'm facing this error: job argocd-redis-secret-init failed: BackoffLimitExceeded

argoproj/argo-cd#18356

Please merge the PR. Thank you !

@mmarisetty
Copy link

I hope this one fix this problem ? Which i'm facing this error: job argocd-redis-secret-init failed: BackoffLimitExceeded
argoproj/argo-cd#18356

Please merge the PR. Thank you !

redisSecretInit:
enabled: false

with this it will work.

Signed-off-by: Marco Maurer <[email protected]>
@mkilchhofer mkilchhofer changed the title fix(argocd) issue-2848 Error in the redis-secret-init/job.yaml for imagepullsecret fix(argocd): Align imagePullSecrets for redis-secret-init Job Sep 25, 2024
Signed-off-by: Marco Maurer (-Kilchhofer) <[email protected]>
@mkilchhofer mkilchhofer marked this pull request as ready for review September 25, 2024 21:52
@mkilchhofer mkilchhofer changed the title fix(argocd): Align imagePullSecrets for redis-secret-init Job fix(argo-cd): Align imagePullSecrets for redis-secret-init Job Sep 25, 2024
@mbevc1 mbevc1 merged commit 4b651b3 into argoproj:main Sep 25, 2024
6 of 7 checks passed
rouke-broersma referenced this pull request in broersma-forslund/homelab Sep 26, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [argo-cd](https://redirect.github.com/argoproj/argo-helm) | patch |
`7.6.3` -> `7.6.4` |

---

### Release Notes

<details>
<summary>argoproj/argo-helm (argo-cd)</summary>

###
[`v7.6.4`](https://redirect.github.com/argoproj/argo-helm/releases/tag/argo-cd-7.6.4)

[Compare
Source](https://redirect.github.com/argoproj/argo-helm/compare/argo-cd-7.6.3...argo-cd-7.6.4)

A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool
for Kubernetes.

#### What's Changed

- chore(deps): update actions/checkout action to v4.2.0 by
[@&#8203;argoproj-renovate](https://redirect.github.com/argoproj-renovate)
in
[https://github.com/argoproj/argo-helm/pull/2937](https://redirect.github.com/argoproj/argo-helm/pull/2937)
- fix(argo-cd): Align imagePullSecrets for redis-secret-init Job by
[@&#8203;DoumLaberge](https://redirect.github.com/DoumLaberge) in
[https://github.com/argoproj/argo-helm/pull/2928](https://redirect.github.com/argoproj/argo-helm/pull/2928)

#### New Contributors

- [@&#8203;DoumLaberge](https://redirect.github.com/DoumLaberge) made
their first contribution in
[https://github.com/argoproj/argo-helm/pull/2928](https://redirect.github.com/argoproj/argo-helm/pull/2928)

**Full Changelog**:
argoproj/argo-helm@argo-cd-7.6.3...argo-cd-7.6.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/broersma-forslund/homelab).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants