fix(argo-cd): Align imagePullSecrets for redis-secret-init Job #2928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correction of the imagepullsecret for redis
DoumLaberge
requested review from
mbevc1,
mkilchhofer,
yu-croco,
jmeridth,
pdrastil and
tico24
as code owners
yu-croco
previously requested changes
Sep 19, 2024
There was a problem hiding this comment.
Thank you for your PR.
Please fulfill the items in your PR description.
I have bumped the chart version according to versioning
I have updated the documentation according to documentation
I have updated the chart changelog with all the changes that come with this pull request according to changelog.
Any new values are backwards compatible and/or have sensible default.
I have signed off all my commits as required by DCO.
My build is green (troubleshooting builds).
Bump chart version to 7.5.3
DoumLaberge
changed the title
DoumLaberge
changed the title
|
Can someone just include the code in the main branch please. I don't have time to jump in all this hoop. Sorry |
yu-croco
dismissed
their stale review
I don't need to be a blocker since all reviewers know the process.
|
I hope this one fix this problem ? |
Please merge the PR. Thank you ! |
redisSecretInit: with this it will work. |
Signed-off-by: Marco Maurer <[email protected]>
mkilchhofer
changed the title
Signed-off-by: Marco Maurer (-Kilchhofer) <[email protected]>
mkilchhofer
approved these changes
Sep 25, 2024
mkilchhofer
changed the title
mbevc1
approved these changes
Sep 25, 2024
rouke-broersma
referenced
this pull request
in broersma-forslund/homelab
Sep 26, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [argo-cd](https://redirect.github.com/argoproj/argo-helm) | patch | `7.6.3` -> `7.6.4` | --- ### Release Notes <details> <summary>argoproj/argo-helm (argo-cd)</summary> ### [`v7.6.4`](https://redirect.github.com/argoproj/argo-helm/releases/tag/argo-cd-7.6.4) [Compare Source](https://redirect.github.com/argoproj/argo-helm/compare/argo-cd-7.6.3...argo-cd-7.6.4) A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool for Kubernetes. #### What's Changed - chore(deps): update actions/checkout action to v4.2.0 by [@​argoproj-renovate](https://redirect.github.com/argoproj-renovate) in [https://github.com/argoproj/argo-helm/pull/2937](https://redirect.github.com/argoproj/argo-helm/pull/2937) - fix(argo-cd): Align imagePullSecrets for redis-secret-init Job by [@​DoumLaberge](https://redirect.github.com/DoumLaberge) in [https://github.com/argoproj/argo-helm/pull/2928](https://redirect.github.com/argoproj/argo-helm/pull/2928) #### New Contributors - [@​DoumLaberge](https://redirect.github.com/DoumLaberge) made their first contribution in [https://github.com/argoproj/argo-helm/pull/2928](https://redirect.github.com/argoproj/argo-helm/pull/2928) **Full Changelog**: argoproj/argo-helm@argo-cd-7.6.3...argo-cd-7.6.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/broersma-forslund/homelab). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correction of the imagepullsecret for redis
Checklist: