-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(argo-cd): Add rights on applicationsets for application controller #2975
base: main
Are you sure you want to change the base?
Conversation
Can you please update the changelog as well? |
Done ! |
Thanks for your contribution. This needs changing as well: https://github.com/argoproj/argo-helm/pull/2975/files#diff-16f38cd1a4674cb682ac9f015fbc1c1ff552f024a8f791c16de0de21a1f65771L28-L29 More on this: https://github.com/argoproj/argo-helm/blob/main/CONTRIBUTING.md#changelog |
Signed-off-by: OpenGuidou <[email protected]>
@@ -19,6 +19,7 @@ rules: | |||
- argoproj.io | |||
resources: | |||
- applications | |||
- applicationsets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @OpenGuidou , thank you for your PR.
Since we follow upstream and we don't see the permission in v2.12.4. 🤔
Ref: https://github.com/argoproj/argo-cd/blob/v2.12.4/manifests/base/application-controller-roles/argocd-application-controller-role.yaml
Can you please make PR for upstream ? Once upstream releases as a new version, we also follow this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure !
Upstream fix: argoproj/argo-cd#20352 |
Fixes #2974
Checklist: