Skip to content

Commit

Permalink
fix bug with promote and last step is a pause
Browse files Browse the repository at this point in the history
Signed-off-by: zachaller <[email protected]>
  • Loading branch information
zachaller committed Jun 29, 2022
1 parent c768700 commit 095af8d
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions rollout/trafficrouting.go
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,10 @@ func (c *rolloutContext) reconcileTrafficRouting() error {

if rolloututil.IsFullyPromoted(c.rollout) {
// when we are fully promoted. desired canary weight should be 0
err := reconciler.RemoveManagedRoutes()
if err != nil {
return err
}
} else if c.pauseContext.IsAborted() {
// when aborted, desired canary weight should immediately be 0 (100% to stable), *unless*
// we are using dynamic stable scaling. In that case, we are dynamically decreasing the
Expand Down

0 comments on commit 095af8d

Please sign in to comment.