Skip to content

Commit

Permalink
fix: Wait for all canary pods to come up in TrafficRouting canary bef…
Browse files Browse the repository at this point in the history
…ore switching traffic (#1663)

Signed-off-by: khhirani <[email protected]>
  • Loading branch information
khhirani authored Nov 18, 2021
1 parent 6edc9c8 commit 30f0e7d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion rollout/trafficrouting.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ func (c *rolloutContext) reconcileTrafficRouting() error {
weightDestinations = append(weightDestinations, c.calculateWeightDestinationsFromExperiment()...)
} else if index != nil {
atDesiredReplicaCount := replicasetutil.AtDesiredReplicaCountsForCanary(c.rollout, c.newRS, c.stableRS, c.otherRSs, nil)
if !atDesiredReplicaCount {
if !atDesiredReplicaCount && !c.rollout.Status.PromoteFull {
// Use the previous weight since the new RS is not ready for a new weight
for i := *index - 1; i >= 0; i-- {
step := c.rollout.Spec.Strategy.Canary.Steps[i]
Expand Down

0 comments on commit 30f0e7d

Please sign in to comment.