fix: flakey TestWriteBackToInformer test (#2621)

* fix: flakey TestWriteBackToInformer test Signed-off-by: zachaller <[email protected]> * change docs to better explain issue Signed-off-by: zachaller <[email protected]> * use built in ToUnstructured function Signed-off-by: zachaller <[email protected]> * no need to put into Unstructured type Signed-off-by: zachaller <[email protected]> * remove commented code and update comments Signed-off-by: zachaller <[email protected]> --------- Signed-off-by: zachaller <[email protected]>
argoproj · Feb 23, 2023 · 4b5d663 · 4b5d663
1 parent 14a2321
commit 4b5d663
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/rollout/controller_test.go b/rollout/controller_test.go
@@ -1948,9 +1948,14 @@ func TestWriteBackToInformer(t *testing.T) {
 	obj, exists, err := c.rolloutsIndexer.GetByKey(roKey)
 	assert.NoError(t, err)
 	assert.True(t, exists)
-	un, ok := obj.(*unstructured.Unstructured)
-	assert.True(t, ok)
-	stableRS, _, _ := unstructured.NestedString(un.Object, "status", "stableRS")
+
+	// The type returned from c.rolloutsIndexer.GetByKey is not always the same type it switches between
+	// *unstructured.Unstructured and *v1alpha1.Rollout the underlying cause is not fully known. We use the
+	// runtime.DefaultUnstructuredConverter to account for this.
+	unObj, err := runtime.DefaultUnstructuredConverter.ToUnstructured(obj)
+	assert.NoError(t, err)
+
+	stableRS, _, _ := unstructured.NestedString(unObj, "status", "stableRS")
 	assert.NotEmpty(t, stableRS)
 	assert.Equal(t, rs1.Labels[v1alpha1.DefaultRolloutUniqueLabelKey], stableRS)
 }