fix: remove outdated ioutil package dependencies (#2583)

Signed-off-by: fengshunli <[email protected]>

hack/gen-crd-spec/main.go

@@ -3,7 +3,7 @@ package main
 import (
 	"encoding/json"
 	"fmt"
-	"io/ioutil"
+	"io"
 	"net/http"
 	"os"
 	"os/exec"
@@ -293,7 +293,7 @@ func loadK8SDefinitions() (spec.Definitions, error) {
 		return nil, err
 	}
 	defer resp.Body.Close()
-	data, err := ioutil.ReadAll(resp.Body)
+	data, err := io.ReadAll(resp.Body)
 	if err != nil {
 		return nil, err
 	}
@@ -442,7 +442,7 @@ func generateKustomizeSchema(crds []*extensionsobj.CustomResourceDefinition, out
 	if err != nil {
 		return err
 	}
-	return ioutil.WriteFile(outputPath, data, 0644)
+	return os.WriteFile(outputPath, data, 0644)
 }
 
 // Generate CRD spec for Rollout Resource
@@ -480,7 +480,7 @@ func main() {
 		if path == "" {
 			panic(fmt.Sprintf("unknown kind: %s", crdKind))
 		}
-		err = ioutil.WriteFile(path, yamlBytes, 0644)
+		err = os.WriteFile(path, yamlBytes, 0644)
 		checkErr(err)
 	}
 }

hack/gen-docs/main.go

@@ -4,16 +4,16 @@ import (
 	"bytes"
 	"fmt"
 	"io"
-	"io/ioutil"
 	"log"
 	"os"
 	"path/filepath"
 	"sort"
 	"strings"
 
+	"gopkg.in/yaml.v2"
+
 	"github.com/argoproj/notifications-engine/pkg/docs"
 	"github.com/spf13/cobra"
-	"gopkg.in/yaml.v2"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 
 	"github.com/argoproj/argo-rollouts/pkg/kubectl-argo-rollouts/cmd"
@@ -42,7 +42,7 @@ func generateNotificationsDocs() {
 func generatePluginsDocs() {
 	tf, o := options.NewFakeArgoRolloutsOptions()
 
-	//Set static config dir so that gen docs does not change depending on what machine it is ran on
+	// Set static config dir so that gen docs does not change depending on what machine it is ran on
 	configDir := "$HOME/.kube/cache"
 	o.ConfigFlags.CacheDir = &configDir
 
@@ -65,7 +65,7 @@ func generatePluginsDocs() {
 func updateMkDocsNav(parent string, child string, files []string) error {
 	trimPrefixes(files, "docs/")
 	sort.Strings(files)
-	data, err := ioutil.ReadFile("mkdocs.yml")
+	data, err := os.ReadFile("mkdocs.yml")
 	if err != nil {
 		return err
 	}
@@ -89,7 +89,7 @@ func updateMkDocsNav(parent string, child string, files []string) error {
 	if err != nil {
 		return err
 	}
-	return ioutil.WriteFile("mkdocs.yml", newmkdocs, 0644)
+	return os.WriteFile("mkdocs.yml", newmkdocs, 0644)
 }
 
 func findNavItem(nav []interface{}, key string) (interface{}, int) {

metricproviders/datadog/datadog.go

@@ -5,7 +5,7 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
-	"io/ioutil"
+	"io"
 	"net/http"
 	"net/url"
 	"os"
@@ -27,7 +27,7 @@ import (
 var unixNow = func() int64 { return timeutil.Now().Unix() }
 
 const (
-	//ProviderType indicates the provider is datadog
+	// ProviderType indicates the provider is datadog
 	ProviderType            = "Datadog"
 	DatadogTokensSecretName = "datadog"
 	DatadogApiKey           = "api-key"
@@ -131,7 +131,7 @@ func (p *Provider) Run(run *v1alpha1.AnalysisRun, metric v1alpha1.Metric) v1alph
 
 func (p *Provider) parseResponse(metric v1alpha1.Metric, response *http.Response) (string, v1alpha1.AnalysisPhase, error) {
 
-	bodyBytes, err := ioutil.ReadAll(response.Body)
+	bodyBytes, err := io.ReadAll(response.Body)
 
 	if err != nil {
 		return "", v1alpha1.AnalysisPhaseError, fmt.Errorf("Received no bytes in response: %v", err)

metricproviders/graphite/api.go

@@ -3,7 +3,7 @@ package graphite
 import (
 	"encoding/json"
 	"fmt"
-	"io/ioutil"
+	"io"
 	"math"
 	"net/http"
 	"net/url"
@@ -53,7 +53,7 @@ func (api APIClient) Query(quer string) ([]dataPoint, error) {
 	}
 	defer r.Body.Close()
 
-	b, err := ioutil.ReadAll(r.Body)
+	b, err := io.ReadAll(r.Body)
 	if err != nil {
 		return []dataPoint{}, err
 	}

metricproviders/influxdb/influxdb_test.go

@@ -3,7 +3,7 @@ package influxdb
 import (
 	"errors"
 	"fmt"
-	"io/ioutil"
+	"io"
 	"strings"
 	"testing"
 
@@ -39,7 +39,7 @@ func TestRunSuccessfully(t *testing.T) {
 ,,0,2020-02-17T22:19:49.747562847Z,2020-02-18T22:19:49.747562847Z,2020-02-18T22:08:44.850214724Z,6.6,f,test,1,adsfasdf
 `
 	reader := strings.NewReader(csvTable)
-	result := influxdb2.NewQueryTableResult(ioutil.NopCloser(reader))
+	result := influxdb2.NewQueryTableResult(io.NopCloser(reader))
 	mock := &mockAPI{response: result}
 	p := NewInfluxdbProvider(mock, e)
 	metric := v1alpha1.Metric{
@@ -71,7 +71,7 @@ func TestRunWithTimeseries(t *testing.T) {
 ,,0,2020-02-17T22:19:49.747562847Z,2020-02-18T22:19:49.747562847Z,2020-02-18T22:08:44.850214724Z,20,f,test,1,adsfasdf
 `
 	reader := strings.NewReader(csvTable)
-	result := influxdb2.NewQueryTableResult(ioutil.NopCloser(reader))
+	result := influxdb2.NewQueryTableResult(io.NopCloser(reader))
 	mock := &mockAPI{response: result}
 	p := NewInfluxdbProvider(mock, e)
 	metric := v1alpha1.Metric{
@@ -102,7 +102,7 @@ func TestRunWithEmptyResult(t *testing.T) {
 ,result,table,_start,_stop,_time,_value,_field,_measurement,a,b
 `
 	reader := strings.NewReader(csvTable)
-	result := influxdb2.NewQueryTableResult(ioutil.NopCloser(reader))
+	result := influxdb2.NewQueryTableResult(io.NopCloser(reader))
 	mock := &mockAPI{response: result}
 	p := NewInfluxdbProvider(mock, *e)
 	metric := v1alpha1.Metric{

metricproviders/kayenta/kayenta.go

@@ -5,7 +5,7 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
-	"io/ioutil"
+	"io"
 	"net/http"
 	"time"
 
@@ -19,7 +19,7 @@ import (
 )
 
 const (
-	//ProviderType indicates the provider is kayenta
+	// ProviderType indicates the provider is kayenta
 	ProviderType   = "Kayenta"
 	scoreURLFormat = `%s/canary/%s`
 
@@ -78,7 +78,7 @@ func getCanaryConfigId(metric v1alpha1.Metric, p *Provider) (string, error) {
 		return "", err
 	}
 
-	data, err := ioutil.ReadAll(response.Body)
+	data, err := io.ReadAll(response.Body)
 	if err != nil {
 		return "", err
 	}
@@ -142,7 +142,7 @@ func (p *Provider) Run(run *v1alpha1.AnalysisRun, metric v1alpha1.Metric) v1alph
 		return metricutil.MarkMeasurementError(newMeasurement, err)
 	}
 
-	data, err := ioutil.ReadAll(response.Body)
+	data, err := io.ReadAll(response.Body)
 	if err != nil {
 		return metricutil.MarkMeasurementError(newMeasurement, err)
 	}
@@ -180,7 +180,7 @@ func (p *Provider) Resume(run *v1alpha1.AnalysisRun, metric v1alpha1.Metric, mea
 		return metricutil.MarkMeasurementError(measurement, err)
 	}
 
-	data, err := ioutil.ReadAll(response.Body)
+	data, err := io.ReadAll(response.Body)
 	if err != nil {
 		return metricutil.MarkMeasurementError(measurement, err)
 	}
@@ -194,7 +194,7 @@ func (p *Provider) Resume(run *v1alpha1.AnalysisRun, metric v1alpha1.Metric, mea
 
 	status, ok, err := unstructured.NestedBool(patch, "complete")
 	if ok {
-		if !status { //resume later since it is incomplete
+		if !status { // resume later since it is incomplete
 			resumeTime := metav1.NewTime(timeutil.Now().Add(resumeDelay))
 			measurement.ResumeAt = &resumeTime
 			measurement.Phase = v1alpha1.AnalysisPhaseRunning