Skip to content

Commit

Permalink
fix: set gopath in makefile
Browse files Browse the repository at this point in the history
We currently assume that GOPATH is set within the developers environment
go has some defaults that get used when no GOPATH is defined. If we use
`go env GOPATH` to set the env var for the Makefile we will then also fall
back to golang defaults which help contributior experiance.

Signed-off-by: zachaller <[email protected]>
  • Loading branch information
zachaller committed Nov 4, 2022
1 parent 076ea43 commit 5e8e2fa
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ E2E_INSTANCE_ID ?= argo-rollouts-e2e
E2E_TEST_OPTIONS ?=
E2E_PARALLEL ?= 1
E2E_WAIT_TIMEOUT ?= 120
GOPATH ?= $(shell go env GOPATH)

override LDFLAGS += \
-X ${PACKAGE}/utils/version.version=${VERSION} \
Expand Down

0 comments on commit 5e8e2fa

Please sign in to comment.