change error wraping for init

Signed-off-by: zachaller <[email protected]>
argoproj · Mar 1, 2023 · c4a6bcb · c4a6bcb
1 parent b31516b
commit c4a6bcb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/metricproviders/plugin/client/client.go b/metricproviders/plugin/client/client.go
@@ -85,8 +85,8 @@ func (m *metricPlugin) startPluginSystem(metric v1alpha1.Metric) (rpc.MetricProv
 			}
 			m.plugin[pluginName] = pluginType
 
-			err = m.plugin[pluginName].InitPlugin()
-			if err.Error() != "" {
+			resp := m.plugin[pluginName].InitPlugin()
+			if resp.HasError() {
 				return nil, fmt.Errorf("unable to initialize plugin via rpc (%s): %w", pluginName, err)
 			}
 		}

diff --git a/rollout/trafficrouting/plugin/client/client.go b/rollout/trafficrouting/plugin/client/client.go
@@ -81,8 +81,8 @@ func (t *trafficPlugin) startPlugin(pluginName string) (rpc.TrafficRouterPlugin,
 		}
 		t.plugin[pluginName] = pluginType
 
-		err = t.plugin[pluginName].InitPlugin()
-		if err.Error() != "" {
+		resp := t.plugin[pluginName].InitPlugin()
+		if resp.HasError() {
 			return nil, fmt.Errorf("unable to initialize plugin via rpc (%s): %w", pluginName, err)
 		}
 	}