Skip to content

Commit

Permalink
chore: Update test and related docs for plugin name standard (#2728)
Browse files Browse the repository at this point in the history
* Update test and related docs for plugin name standard

Signed-off-by: Wilson Wu <[email protected]>

* Add DaoCloud into USERS

Signed-off-by: Wilson Wu <[email protected]>

* fix ordering and one missing import

Signed-off-by: zachaller <[email protected]>

* fix ordering and one missing import

Signed-off-by: zachaller <[email protected]>

---------

Signed-off-by: Wilson Wu <[email protected]>
Signed-off-by: zachaller <[email protected]>
Co-authored-by: zachaller <[email protected]>
  • Loading branch information
wilsonwu and zachaller authored Apr 20, 2023
1 parent e7e45f7 commit ddce671
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 7 deletions.
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ test-e2e: install-devtools-local

.PHONY: test-unit
test-unit: install-devtools-local
${DIST_DIR}/gotestsum --junitfile=junit.xml --format=testname -- -covermode=count -coverprofile=coverage.out `go list ./... | grep -v ./test/cmd/sample-metrics-plugin`
${DIST_DIR}/gotestsum --junitfile=junit.xml --format=testname -- -covermode=count -coverprofile=coverage.out `go list ./... | grep -v ./test/cmd/metrics-plugin-sample`


.PHONY: coverage
Expand Down Expand Up @@ -284,9 +284,9 @@ checksums:
# https://www.jetbrains.com/help/go/attach-to-running-go-processes-with-debugger.html
.PHONY: build-sample-metric-plugin-debug
build-sample-metric-plugin-debug:
go build -gcflags="all=-N -l" -o metric-plugin test/cmd/sample-metrics-plugin/main.go
go build -gcflags="all=-N -l" -o metric-plugin test/cmd/metrics-plugin-sample/main.go

.PHONY: build-sample-traffic-plugin-debug
build-sample-traffic-plugin-debug:
go build -gcflags="all=-N -l" -o traffic-plugin test/cmd/sample-trafficrouter-plugin/main.go
go build -gcflags="all=-N -l" -o traffic-plugin test/cmd/trafficrouter-plugin-sample/main.go

1 change: 1 addition & 0 deletions USERS.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Organizations below are **officially** using Argo Rollouts. Please send a PR wit
1. [Calm](https://www.calm.com/)
1. [Codefresh](https://codefresh.io/)
1. [Credit Karma](https://creditkarma.com/)
1. [DaoCloud](https://daocloud.io)
1. [Databricks](https://github.com/databricks)
1. [Devtron Labs](https://github.com/devtron-labs/devtron)
1. [Farfetch](https://www.farfetch.com/)
Expand Down
4 changes: 2 additions & 2 deletions docs/plugins.md
Original file line number Diff line number Diff line change
Expand Up @@ -151,5 +151,5 @@ for the plugin to use. This will probably affect traffic router plugins more tha

There are two sample plugins within the argo-rollouts repo that you can use as a reference for creating your own plugin.

* [Sample Metrics Plugin](https://github.com/argoproj/argo-rollouts/tree/master/test/cmd/sample-metrics-plugin)
* [Sample Traffic Router Plugin](https://github.com/argoproj/argo-rollouts/tree/master/test/cmd/sample-trafficrouter-plugin)
* [Metrics Plugin Sample](https://github.com/argoproj/argo-rollouts/tree/master/test/cmd/metrics-plugin-sample)
* [Traffic Router Plugin Sample](https://github.com/argoproj/argo-rollouts/tree/master/test/cmd/trafficrouter-plugin-sample)
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package main

import (
"github.com/argoproj/argo-rollouts/metricproviders/plugin/rpc"
"github.com/argoproj/argo-rollouts/test/cmd/sample-metrics-plugin/internal/plugin"
"github.com/argoproj/argo-rollouts/test/cmd/metrics-plugin-sample/internal/plugin"
goPlugin "github.com/hashicorp/go-plugin"
log "github.com/sirupsen/logrus"
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"strings"

rolloutsPlugin "github.com/argoproj/argo-rollouts/rollout/trafficrouting/plugin/rpc"
"github.com/argoproj/argo-rollouts/test/cmd/sample-trafficrouter-plugin/internal/plugin"
"github.com/argoproj/argo-rollouts/test/cmd/trafficrouter-plugin-sample/internal/plugin"
goPlugin "github.com/hashicorp/go-plugin"
log "github.com/sirupsen/logrus"
)
Expand Down

0 comments on commit ddce671

Please sign in to comment.