fix(analysis): graphite metric provider - nil pointer dereference

argoproj · Apr 30, 2023 · efe0e91 · efe0e91
1 parent 96f164f
commit efe0e91
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/metricproviders/graphite/api.go b/metricproviders/graphite/api.go
@@ -68,6 +68,10 @@ func (api APIClient) Query(quer string) ([]dataPoint, error) {
 		return []dataPoint{}, err
 	}
 
+	if len(result) == 0 {
+		return []dataPoint{}, nil
+	}
+
 	return result[0].DataPoints, nil
 }
 

diff --git a/metricproviders/graphite/api_test.go b/metricproviders/graphite/api_test.go
@@ -82,6 +82,15 @@ func TestQuery(t *testing.T) {
 			}
 		]`, value, timestamp),
 		200,
+	}, {
+		"graphite response with empty array",
+		query,
+		targetQuery,
+		fromQuery,
+		[]dataPoint{},
+		nil,
+		`[]`,
+		200,
 	}, {
 		"graphite response body with invalid JSON",
 		query,