Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard should allow promote/promote-full at any time #1581

Closed
bpoland opened this issue Oct 14, 2021 · 1 comment · Fixed by #1669
Closed

Dashboard should allow promote/promote-full at any time #1581

bpoland opened this issue Oct 14, 2021 · 1 comment · Fixed by #1669
Labels
dashboard enhancement New feature or request

Comments

@bpoland
Copy link
Contributor

bpoland commented Oct 14, 2021

Summary

Currently the rollout dashboard disables the promote and promote-full buttons at certain points (seems to be when scaling canary/setting weight requires pods to be started and become ready). The CLI options do not have this restriction, so I think the dashboard should also allow promoting at any time.

Use Cases

When I want to promote/promote-full while pods are starting

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.
@bpoland bpoland added the enhancement New feature or request label Oct 14, 2021
@jessesuen
Copy link
Member

Yes, this seems reasonable. Promote and promote-full should be available anytime during an update (but not when fully rollouted out at a steady state).

For reference, here is when Argo CD presents them as options (resume is similar to promote in the UI).
https://github.com/argoproj/argo-cd/blob/master/resource_customizations/argoproj.io/Rollout/actions/discovery.lua

@bpoland bpoland mentioned this issue Nov 5, 2021
Closed
bpoland added a commit to bpoland/argo-rollouts that referenced this issue Nov 24, 2021
@bpoland
fix: dashboard promote buttons disabled during deploy
2178f40 
- keep promote and abort buttons enabled while deploying
- disable them at all other times
- also, only enable retry button when Rollout is degraded

Fixes argoproj#1581
bpoland added a commit to bpoland/argo-rollouts that referenced this issue Nov 24, 2021
@bpoland
fix: dashboard promote buttons disabled during deploy
9bfae30 
- keep promote and abort buttons enabled while deploying
- disable them at all other times
- also, only enable retry button when Rollout is degraded

Fixes argoproj#1581

Signed-off-by: Ben Poland <[email protected]>
bpoland added a commit to bpoland/argo-rollouts that referenced this issue Nov 24, 2021
@bpoland
fix: dashboard promote buttons disabled during deploy
bc20e4a 
- keep promote and abort buttons enabled while deploying
- disable them at all other times
- also, only enable retry button when Rollout is degraded

Fixes argoproj#1581

Signed-off-by: Ben Poland <[email protected]>
@bpoland bpoland mentioned this issue Nov 24, 2021
Merged
6 tasks
@harikrongali harikrongali mentioned this issue Jan 3, 2022
Closed
alexmt pushed a commit that referenced this issue Jan 4, 2022
@bpoland
fix: dashboard promote buttons disabled during deploy (#1669)
c291d2d 
- keep promote and abort buttons enabled while deploying
- disable them at all other times
- also, only enable retry button when Rollout is degraded

Fixes #1581

Signed-off-by: Ben Poland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dashboard enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: dashboard promote buttons disabled during deploy bpoland/argo-rollouts
3 participants
@jessesuen @bpoland @kostis-codefresh