Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argo Rollouts docs should prioritize k3d #1750

Closed
crenshaw-dev opened this issue Jan 6, 2022 · 3 comments · Fixed by #1867
Closed

Argo Rollouts docs should prioritize k3d #1750

crenshaw-dev opened this issue Jan 6, 2022 · 3 comments · Fixed by #1867
Labels
docs Needs documentation/release notes enhancement New feature or request good first issue Good for newcomers no-issue-activity

Comments

@crenshaw-dev
Copy link
Member

Summary

The Argo Rollouts contribution docs should use k3d instead of Minikube. This will bring it in line with the recommended setup for Argo CD (and, I believe, Workflows).

Use Cases

New developers starting with Argo Rollouts will have a better experience with k3d (we've encountered quite a few issues with Minikube), and they'll have a more consistent experience if they choose to also work on other Argo projects.

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.
@crenshaw-dev crenshaw-dev added enhancement New feature or request docs Needs documentation/release notes labels Jan 6, 2022
@danielhelfand danielhelfand mentioned this issue Feb 17, 2022
Merged
6 tasks
@blkperl blkperl added the good first issue Good for newcomers label Feb 23, 2022
@iam-veeramalla
Copy link
Member

Hi @crenshaw-dev , There is already a PR for this by @danielhelfand #1867 .. Do you think anything else is required on the PR. I will be more than happy to contribute or we can close this.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

zachaller pushed a commit that referenced this issue Apr 4, 2023
@danielhelfand
docs: update contributions.md to include k3d as recommended cluster, …
f9a3914 
…add details on e2e test setup, and update kubectl install link. Fixes #1750 (#1867)

* docs: add k3d as recommended cluster

Signed-off-by: Daniel Helfand <[email protected]>

* docs: add details on setting up cluster for e2e tests

Signed-off-by: Daniel Helfand <[email protected]>

* docs: update kubectl install docs

Signed-off-by: Daniel Helfand <[email protected]>

---------

Signed-off-by: Daniel Helfand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Needs documentation/release notes enhancement New feature or request good first issue Good for newcomers no-issue-activity
Projects
None yet
Milestone
No milestone
3 participants
@blkperl @crenshaw-dev @iam-veeramalla