build: set GOPATH in Makefile #2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently assume that GOPATH is set within the developers environment go has some defaults that get used when no GOPATH is defined. If we use `go env GOPATH` to set the env var for the Makefile we will then also fall back to golang defaults which help contributior experiance. Signed-off-by: zachaller <[email protected]>
alexef
reviewed
Nov 4, 2022
| @@ -23,6 +23,7 @@ E2E_INSTANCE_ID ?= argo-rollouts-e2e | |||
| E2E_TEST_OPTIONS ?= | |||
| E2E_PARALLEL ?= 1 | |||
| E2E_WAIT_TIMEOUT ?= 120 | |||
| GOPATH ?= $(shell go env GOPATH) | |||
alexef
approved these changes
Nov 4, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportBase: 82.76% // Head: 82.76% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2398 +/- ##
=======================================
Coverage 82.76% 82.76%
=======================================
Files 121 121
Lines 18536 18536
=======================================
Hits 15341 15341
Misses 2410 2410
Partials 785 785 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
leoluz
approved these changes
Nov 4, 2022
jandersen-plaid
pushed a commit
to jandersen-plaid/argo-rollouts
that referenced
this pull request
Nov 8, 2022
We currently assume that GOPATH is set within the developers environment go has some defaults that get used when no GOPATH is defined. If we use `go env GOPATH` to set the env var for the Makefile we will then also fall back to golang defaults which help contributior experiance. Signed-off-by: zachaller <[email protected]> Signed-off-by: zachaller <[email protected]>
jandersen-plaid
pushed a commit
to jandersen-plaid/argo-rollouts
that referenced
this pull request
Nov 26, 2022
We currently assume that GOPATH is set within the developers environment go has some defaults that get used when no GOPATH is defined. If we use `go env GOPATH` to set the env var for the Makefile we will then also fall back to golang defaults which help contributior experiance. Signed-off-by: zachaller <[email protected]> Signed-off-by: zachaller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently assume that GOPATH is set within the developers environment go has some defaults that get used when no GOPATH is defined. If we use
go env GOPATHto set the env var for the Makefile we will then also fall back to golang defaults which help contributior experiance.Signed-off-by: zachaller [email protected]
Checklist:
"fix(controller): Updates such and such. Fixes #1234".