-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove namespaced crds #2516
Conversation
Signed-off-by: Manolis Sfendourakis <[email protected]>
Signed-off-by: Manolis Sfendourakis <[email protected]>
Codecov ReportBase: 81.70% // Head: 81.70% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2516 +/- ##
=======================================
Coverage 81.70% 81.70%
=======================================
Files 126 126
Lines 19135 19135
=======================================
Hits 15634 15634
Misses 2708 2708
Partials 793 793 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Can we also update https://argo-rollouts.readthedocs.io/en/stable/installation/ to mention the two different installation methods? |
Signed-off-by: Manolis Sfendourakis <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
Sure! |
* chore: Remove CRDs from namespaced installation Signed-off-by: Manolis Sfendourakis <[email protected]> * docs: Add README for manifests Signed-off-by: Manolis Sfendourakis <[email protected]> * docs: Update installation methods Signed-off-by: Manolis Sfendourakis <[email protected]> Signed-off-by: Manolis Sfendourakis <[email protected]>
Fixes: #2359
Removed CRDs installation in the namespaced installation.
Also added a small README inside the manifests directory. Please let me know if it needs some more information in it.
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.