Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for traffic router plugins #2573

Merged
merged 50 commits into from
Mar 2, 2023

Conversation

zachaller
Copy link
Collaborator

@zachaller zachaller commented Feb 7, 2023

Add traffic router plugin support

This is a continuation of plugins support from #2514

There are two things from the metrics plugin PR that needs to be implemented here still that is a refactor of test to be BDD style. The other is to support multiple plugins names by standardizing around possibly github repo names for the config key for both metrics plugins and traffic router plugins this will require generating safe file names from plugins names like argoproj-labs/sample-rollouts-metric-plugin.

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Patch coverage: 84.34% and project coverage change: +0.01 🎉

Comparison is base (535f244) 81.52% compared to head (c4a6bcb) 81.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2573      +/-   ##
==========================================
+ Coverage   81.52%   81.54%   +0.01%     
==========================================
  Files         131      133       +2     
  Lines       19587    19768     +181     
==========================================
+ Hits        15969    16120     +151     
- Misses       2797     2820      +23     
- Partials      821      828       +7     
Impacted Files Coverage Δ
rollout/trafficrouting.go 72.53% <0.00%> (-3.21%) ⬇️
utils/plugin/downloader.go 59.12% <57.14%> (-0.42%) ⬇️
utils/plugin/plugin.go 47.05% <57.14%> (-6.79%) ⬇️
metricproviders/plugin/rpc/rpc.go 93.23% <78.57%> (-6.77%) ⬇️
rollout/trafficrouting/plugin/rpc/rpc.go 95.86% <95.86%> (ø)
...ricproviders/plugin/rpc/rpc_test_implementation.go 100.00% <100.00%> (+8.57%) ⬆️
...afficrouting/plugin/rpc/rpc_test_implementation.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Go Published Test Results

1 870 tests   1 870 ✔️  2m 30s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit c4a6bcb.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

E2E Tests Published Test Results

    2 files      2 suites   1h 39m 51s ⏱️
  96 tests   91 ✔️ 3 💤 2
194 runs  186 ✔️ 6 💤 2

For more details on these failures, see this check.

Results for commit c4a6bcb.

♻️ This comment has been updated with latest results.

Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
docs/features/traffic-management/plugins.md Outdated Show resolved Hide resolved
docs/features/traffic-management/plugins.md Outdated Show resolved Hide resolved
docs/plugins.md Outdated Show resolved Hide resolved
docs/plugins.md Outdated Show resolved Hide resolved
docs/plugins.md Outdated Show resolved Hide resolved
@zachaller zachaller added this to the v1.5 milestone Feb 15, 2023
Signed-off-by: zachaller <[email protected]>
docs/plugins.md Outdated Show resolved Hide resolved
docs/plugins.md Outdated Show resolved Hide resolved
Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments

rollout/trafficrouting/plugin/plugin.go Outdated Show resolved Hide resolved
rollout/trafficrouting/plugin/rpc/rpc.go Outdated Show resolved Hide resolved
@zachaller zachaller marked this pull request as ready for review March 1, 2023 22:15
@sonarcloud
Copy link

sonarcloud bot commented Mar 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
6.4% 6.4% Duplication

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaller zachaller merged commit b787cc5 into argoproj:master Mar 2, 2023
@izturn izturn mentioned this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants