-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(analysis): Graphite metric provider - index out of range [0] with length 0 #2751
Conversation
… length 0 Signed-off-by: mdsjip <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2751 +/- ##
=======================================
Coverage 81.62% 81.63%
=======================================
Files 133 133
Lines 20157 20160 +3
=======================================
+ Hits 16454 16457 +3
Misses 2849 2849
Partials 854 854
☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@zachaller will these changes be included in the next release soon? 🙂 |
Rare case, but seen in the wild: Graphite APIs returning response body with just an empty array:
[]
This PR allows to handle this case by checking it and returning an empty
dataPoint
array.Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.