-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add prometheus timeout #2893
Merged
zachaller
merged 4 commits into
argoproj:master
from
AhmedGrati:feat-add-prometheus-timeout
Jul 25, 2023
Merged
feat: Add prometheus timeout #2893
zachaller
merged 4 commits into
argoproj:master
from
AhmedGrati:feat-add-prometheus-timeout
Jul 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhmedGrati
changed the title
Feat add prometheus timeout
[WIP] feat: Add prometheus timeout
Jul 19, 2023
AhmedGrati
force-pushed
the
feat-add-prometheus-timeout
branch
2 times, most recently
from
July 19, 2023 21:00
9abc31d
to
ed9935b
Compare
AhmedGrati
changed the title
[WIP] feat: Add prometheus timeout
feat: Add prometheus timeout [WIP]
Jul 19, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2893 +/- ##
==========================================
+ Coverage 81.68% 81.72% +0.03%
==========================================
Files 133 133
Lines 20309 20336 +27
==========================================
+ Hits 16589 16619 +30
+ Misses 2862 2860 -2
+ Partials 858 857 -1
☔ View full report in Codecov by Sentry. |
AhmedGrati
force-pushed
the
feat-add-prometheus-timeout
branch
3 times, most recently
from
July 23, 2023 12:49
731b89a
to
44f66e2
Compare
AhmedGrati
changed the title
feat: Add prometheus timeout [WIP]
feat: Add prometheus timeout
Jul 23, 2023
Signed-off-by: AhmedGrati <[email protected]>
Signed-off-by: AhmedGrati <[email protected]>
AhmedGrati
force-pushed
the
feat-add-prometheus-timeout
branch
from
July 23, 2023 18:15
942c4e5
to
f5a4d82
Compare
zachaller
reviewed
Jul 24, 2023
zachaller
reviewed
Jul 24, 2023
Signed-off-by: AhmedGrati <[email protected]>
AhmedGrati
force-pushed
the
feat-add-prometheus-timeout
branch
from
July 24, 2023 17:27
f5a4d82
to
d4e2066
Compare
zachaller
approved these changes
Jul 25, 2023
Signed-off-by: zachaller <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2892.
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.