Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add required ingress permission #2933

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

zachaller
Copy link
Collaborator

@zachaller zachaller commented Aug 4, 2023

this permissions is required for ingresses to be updated

@zachaller zachaller requested a review from leoluz August 4, 2023 15:29
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
17.0% 17.0% Duplication

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (378e3d3) 81.75% compared to head (510aa48) 81.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2933   +/-   ##
=======================================
  Coverage   81.75%   81.75%           
=======================================
  Files         133      133           
  Lines       20338    20338           
=======================================
  Hits        16627    16627           
  Misses       2855     2855           
  Partials      856      856           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Go Published Test Results

2 033 tests   2 033 ✔️  2m 39s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit 510aa48.

@zachaller zachaller enabled auto-merge (squash) August 4, 2023 15:46
@zachaller zachaller merged commit e2467fe into argoproj:master Aug 4, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants