Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replace patchesStrategicMerge with patches in tests/docs #3010

Merged

Conversation

therealdwright
Copy link
Contributor

@therealdwright therealdwright commented Sep 3, 2023

This update ensures documentation and test examples reflect the use
of the newer patches method, transitioning away from the deprecated
patchesStrategicMerge. This aligns with current best practices and
recommendations from the kustomize project.

Signed-off-by: Daniel Wright [email protected]

Closes #3009

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

This update ensures documentation and test examples reflect the use
of the newer `patches` method, transitioning away from the deprecated
`patchesStrategicMerge`. This aligns with current best practices and
recommendations from the kustomize project.

Signed-off-by: Daniel Wright <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Sep 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (607de81) 81.74% compared to head (e18bba1) 81.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3010   +/-   ##
=======================================
  Coverage   81.74%   81.74%           
=======================================
  Files         134      134           
  Lines       20386    20386           
=======================================
  Hits        16665    16665           
  Misses       2865     2865           
  Partials      856      856           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023

Go Published Test Results

2 044 tests   2 044 ✔️  2m 39s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit e18bba1.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023

E2E Tests Published Test Results

    4 files      4 suites   3h 39m 37s ⏱️
102 tests   87 ✔️   6 💤   9
424 runs  384 ✔️ 24 💤 16

For more details on these failures, see this check.

Results for commit e18bba1.

@zachaller zachaller merged commit b14679b into argoproj:master Sep 5, 2023
26 checks passed
@therealdwright therealdwright deleted the update-kustomize-patches-usage branch September 6, 2023 02:58
phclark pushed a commit to phclark/argo-rollouts that referenced this pull request Oct 13, 2023
…rgoproj#3010)

This update ensures documentation and test examples reflect the use
of the newer `patches` method, transitioning away from the deprecated
`patchesStrategicMerge`. This aligns with current best practices and
recommendations from the kustomize project.

Signed-off-by: Daniel Wright <[email protected]>
Signed-off-by: Philip Clark <[email protected]>
phclark pushed a commit to phclark/argo-rollouts that referenced this pull request Oct 15, 2023
…rgoproj#3010)

This update ensures documentation and test examples reflect the use
of the newer `patches` method, transitioning away from the deprecated
`patchesStrategicMerge`. This aligns with current best practices and
recommendations from the kustomize project.

Signed-off-by: Daniel Wright <[email protected]>
Signed-off-by: Philip Clark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tests/docs to use kustomize patches over deprecated patchesStrategicMerge
2 participants