feat: automatically scale down Deployment after migrating to Rollout #3111

balasoiuroxana · 2023-10-17T12:24:52Z

fixes: #2748

Checklist:

Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
I've signed my commits with DCO
I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
My builds are green. Try syncing with master if they are not.
My organization is added to USERS.md.

github-actions · 2023-10-17T13:07:06Z

Go Published Test Results

2 089 tests 2 089 ✔️ 2m 48s ⏱️
  118 suites       0 💤
      1 files       0 ❌

Results for commit b57a8fb.

♻️ This comment has been updated with latest results.

github-actions · 2023-10-17T13:20:55Z

E2E Tests Published Test Results

    4 files     4 suites 3h 31m 22s ⏱️
106 tests   96 ✔️   6 💤   4 ❌
438 runs 400 ✔️ 24 💤 14 ❌

For more details on these failures, see this check.

Results for commit b57a8fb.

♻️ This comment has been updated with latest results.

carlossg · 2023-10-18T15:41:37Z

fixes #2748

codecov · 2023-10-24T11:23:35Z

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c067a69) 81.80% compared to head (b57a8fb) 81.81%.
Report is 2 commits behind head on master.

Files	Patch %	Lines
rollout/replicaset.go	76.92%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3111      +/-   ##
==========================================
+ Coverage   81.80%   81.81%   +0.01%     
==========================================
  Files         134      135       +1     
  Lines       20576    20621      +45     
==========================================
+ Hits        16832    16871      +39     
- Misses       2875     2880       +5     
- Partials      869      870       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dharma-rise · 2023-11-03T19:17:32Z

Any updates?

zachaller · 2023-11-10T04:24:38Z

Can we add some documentation here and here on the behavior of all the scaledown options etc?

balasoiuroxana · 2023-11-10T18:22:19Z

rollout/sync.go

@@ -378,6 +378,12 @@ func (c *rolloutContext) scaleReplicaSet(rs *appsv1.ReplicaSet, newScale int32,
 			revision, _ := replicasetutil.Revision(rs)
 			c.recorder.Eventf(rollout, record.EventOptions{EventReason: conditions.ScalingReplicaSetReason}, conditions.ScalingReplicaSetMessage, scalingOperation, rs.Name, revision, oldScale, newScale)
 			c.replicaSetInformer.GetIndexer().Update(rs)
+			if rollout.Spec.WorkloadRef != nil && rollout.Spec.WorkloadRef.ScaleDown == v1alpha1.ScaleDownProgressively {


I realized that for the ScaleDownProgressively option the deployment will be scaled down without waiting for the rollout replicas to become available.
Do you have any suggestions where we can test that? We should scale down the deployment only after the replicas become available.
cc: @carlossg

I changed the logic for the progressively scaleDown option, now the deployment is scaled down as the rollout is scaled up and its replicas become ready.

zachaller · 2023-11-22T14:48:43Z

Is this ready for a second review now?

balasoiuroxana · 2023-11-22T14:51:44Z

@zachaller , yes it is ready

Signed-off-by: balasoiu <[email protected]>

zachaller · 2023-12-04T16:51:57Z

@balasoiuroxana looks good and ready to merge, can you fix the last small conflict?

sonarcloud · 2023-12-05T11:09:48Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
1.0% Duplication

…rgoproj#3111) Automatically scale down Deployment after migrating to Rollout Signed-off-by: balasoiu <[email protected]> Co-authored-by: balasoiu <[email protected]> Signed-off-by: ashutosh16 <[email protected]>

Ahmed-Elkollaly · 2023-12-23T15:28:23Z

@balasoiuroxana @zachaller Thanks for this awesome feature but I don't see it in the latest argo rollout version v1.6.4. when it's expected to be rolled out?

zachaller · 2023-12-28T13:58:14Z

It will be available in 1.7 we don't have a set date on that yet, I want to try and get step plugins in 1.7

rmn-lux · 2024-02-28T11:53:31Z

It will be available in 1.7 we don't have a set date on that yet, I want to try and get step plugins in 1.7

Hello, is there any information about the release date of v1.7?

SleepyBrett · 2024-05-30T17:18:24Z

Couldn't you also do this the other way as well.

On deletion of the rollout the reconciler takes the current replicas of the rollout and applies it to the referenced deployment (if available). Once the pods become healthy, delete the rollout's child replica-sets and remove the finalizer?

balasoiuroxana force-pushed the deployments-scale-down branch from cdfc6c2 to de33aee Compare October 17, 2023 12:33

balasoiuroxana changed the title ~~Automatically scale down Deployment after migrating to Rollout~~ feat: automatically scale down Deployment after migrating to Rollout Oct 17, 2023

balasoiuroxana force-pushed the deployments-scale-down branch 3 times, most recently from b283ca7 to f5b4bbf Compare October 18, 2023 14:14

balasoiuroxana force-pushed the deployments-scale-down branch from 54356c3 to fe96101 Compare October 27, 2023 10:00

todaywasawesome requested review from zachaller and kostis-codefresh November 7, 2023 17:31

balasoiuroxana force-pushed the deployments-scale-down branch 3 times, most recently from 84d42a5 to 24d5cc2 Compare November 9, 2023 09:05

balasoiuroxana commented Nov 10, 2023

View reviewed changes

balasoiuroxana force-pushed the deployments-scale-down branch from 6e06f5e to cb1824b Compare November 22, 2023 13:48

zachaller added this to the v1.7 milestone Nov 22, 2023

Automatically scale down Deployment after migrating to Rollout

b87e97e

Signed-off-by: balasoiu <[email protected]>

zachaller force-pushed the deployments-scale-down branch from cb1824b to b87e97e Compare December 1, 2023 14:53

zachaller approved these changes Dec 4, 2023

View reviewed changes

Merge branch 'master' into deployments-scale-down

b57a8fb

zachaller merged commit 0ec8519 into argoproj:master Dec 5, 2023
24 checks passed

mildmojo mentioned this pull request Apr 4, 2024

Docs: Current Rollout specification uses spec.workloadRef.scaleDown, which does not exist in latest v1.6.6 #3505

Closed

yyzxw mentioned this pull request Jul 24, 2024

fix(argo-rollouts): update rollout cluster role argoproj/argo-helm#2844

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: automatically scale down Deployment after migrating to Rollout #3111

feat: automatically scale down Deployment after migrating to Rollout #3111

balasoiuroxana commented Oct 17, 2023 •

edited by zachaller

Loading

github-actions bot commented Oct 17, 2023 •

edited

Loading

github-actions bot commented Oct 17, 2023 •

edited

Loading

carlossg commented Oct 18, 2023

codecov bot commented Oct 24, 2023 •

edited

Loading

dharma-rise commented Nov 3, 2023

zachaller commented Nov 10, 2023

balasoiuroxana Nov 10, 2023

balasoiuroxana Nov 16, 2023

zachaller commented Nov 22, 2023 •

edited

Loading

balasoiuroxana commented Nov 22, 2023

zachaller commented Dec 4, 2023

sonarcloud bot commented Dec 5, 2023

Ahmed-Elkollaly commented Dec 23, 2023

zachaller commented Dec 28, 2023

rmn-lux commented Feb 28, 2024

SleepyBrett commented May 30, 2024

feat: automatically scale down Deployment after migrating to Rollout #3111

feat: automatically scale down Deployment after migrating to Rollout #3111

Conversation

balasoiuroxana commented Oct 17, 2023 • edited by zachaller Loading

github-actions bot commented Oct 17, 2023 • edited Loading

Go Published Test Results

github-actions bot commented Oct 17, 2023 • edited Loading

E2E Tests Published Test Results

carlossg commented Oct 18, 2023

codecov bot commented Oct 24, 2023 • edited Loading

Codecov Report

dharma-rise commented Nov 3, 2023

zachaller commented Nov 10, 2023

balasoiuroxana Nov 10, 2023

Choose a reason for hiding this comment

balasoiuroxana Nov 16, 2023

Choose a reason for hiding this comment

zachaller commented Nov 22, 2023 • edited Loading

balasoiuroxana commented Nov 22, 2023

zachaller commented Dec 4, 2023

sonarcloud bot commented Dec 5, 2023

Ahmed-Elkollaly commented Dec 23, 2023

zachaller commented Dec 28, 2023

rmn-lux commented Feb 28, 2024

SleepyBrett commented May 30, 2024

balasoiuroxana commented Oct 17, 2023 •

edited by zachaller

Loading

github-actions bot commented Oct 17, 2023 •

edited

Loading

github-actions bot commented Oct 17, 2023 •

edited

Loading

codecov bot commented Oct 24, 2023 •

edited

Loading

zachaller commented Nov 22, 2023 •

edited

Loading