feat: Rollouts UI List view refresh #3118

phclark · 2023-10-19T12:55:41Z

Checklist:

Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
I've signed my commits with DCO
I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
My builds are green. Try syncing with master if they are not.
My organization is added to USERS.md.

Signed-off-by: Philip Clark <[email protected]>

…lark/argo-rollouts into phclark-feat/home-ui-refresh

github-actions · 2023-10-19T13:15:01Z

Go Published Test Results

2 085 tests 2 085 ✔️ 2m 47s ⏱️
  118 suites       0 💤
      1 files       0 ❌

Results for commit c93191d.

♻️ This comment has been updated with latest results.

codecov · 2023-10-19T13:15:31Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3e940a6) 81.85% compared to head (c93191d) 81.84%.
Report is 20 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3118      +/-   ##
==========================================
- Coverage   81.85%   81.84%   -0.02%     
==========================================
  Files         134      134              
  Lines       20556    20558       +2     
==========================================
- Hits        16826    16825       -1     
- Misses       2866     2869       +3     
  Partials      864      864

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2023-10-19T13:40:18Z

E2E Tests Published Test Results

    4 files     4 suites 3h 26m 24s ⏱️
103 tests   93 ✔️   6 💤 4 ❌
420 runs 388 ✔️ 24 💤 8 ❌

For more details on these failures, see this check.

Results for commit c93191d.

♻️ This comment has been updated with latest results.

Signed-off-by: Philip Clark <[email protected]>

phclark · 2023-10-23T13:33:00Z

Is it possible for these e2e tests to be flaky? My previous commit passed all tests, but last commit failed the 1.26 e2e test even though the change was completed unrelated (only a minor UI code change). Can we rerun the test (I don't believe I have permissions)

zachaller · 2023-10-28T13:59:21Z

Yea it looks like something failed at githubs level i restarted it

Signed-off-by: Philip Clark <[email protected]>

…lark/argo-rollouts into phclark-feat/home-ui-refresh

ashutosh16 · 2023-11-02T07:10:36Z

@phclark Would you be able to provide a screenshot/video of the changes you propose?

Signed-off-by: Philip Clark <[email protected]>

phclark · 2023-11-08T19:57:58Z

Hi @ashutosh16 ! I've got a video demo for you, showing off the new functionality. We've got this running internally in our organization with a hundred or so engineers using it daily, so I've got a fair amount of confidence things work as intended but I do also encourage you to test it yourself to see if the functionality makes sense.

https://jmp.sh/s/yEe36uy2F8swAcYnthe3

ashutosh16 · 2023-11-10T02:36:18Z

https://jmp.sh/s/yEe36uy2F8swAcYnthe3
link doesn't work for me

Would you able to confirm if these are intended change? look very promising..

ui/src/app/components/header/header.tsx

ui/src/app/components/rollouts-home/rollouts-home.tsx

ashutosh16 · 2023-11-10T04:11:52Z

ui/src/app/components/rollouts-home/rollouts-home.tsx

+                favoritesMatches = true;
+            }
+            if (filters.showRequiresAttention && (r.status === 'Degraded' || (r.status === 'Paused' && r.message !== 'CanaryPauseStep'))) {
+                requiresAttentionMatches = true;


nice to have:
When filtering by name or !. Filter by health on the toolbar.

Screen.Recording.2023-11-09.at.8.10.12.PM.mov

ui/src/app/components/rollouts-toolbar/rollouts-toolbar.tsx

ashutosh16 · 2023-11-10T05:43:00Z

ui/src/app/components/rollouts-table/rollouts-table.tsx

+            sorter: (a: any, b: any) => a.strategy.localeCompare(b.strategy),
+            render: (strategy: string) => {
+                return (
+                    <InfoItemRow label={''} items={{content: strategy, icon: strategy === 'BlueGreen' ? 'fa-palette' : 'fa-dove', kind: strategy.toLowerCase() as InfoItemKind}} />


add css style to make it center

I wasn't able to get this to work with center alignment, but I think it looks really clean when aligned left

Signed-off-by: Philip Clark <[email protected]>

ashutosh16 · 2023-11-16T17:39:37Z

ui/src/app/components/rollout-widget/rollout-widget.tsx

+    return false;
+};
+
+export const RolloutWidget = (props: {


Since there is already a component with same name. Would it be better to rename it differently.

@ashutosh16 I've renamed my new widget to RolloutGridWidget

I'll review the PR today.

Signed-off-by: Philip Clark <[email protected]>

sonarcloud · 2023-11-17T02:34:41Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
19 Code Smells

No Coverage information
3.9% Duplication

ashutosh16

LGTM

ashutosh16 · 2023-11-28T20:11:15Z

@zachaller I have verified the UI and the changes look good to me. Do you want to merge the PR?

zachaller

Thanks for the contributions!

phclark and others added 3 commits October 18, 2023 19:13

feat: Rollouts UI Refresh

4024109

Signed-off-by: Philip Clark <[email protected]>

add test for labels and annotations

925aab6

Signed-off-by: Philip Clark <[email protected]>

Merge branch 'master' into phclark-feat/home-ui-refresh

2039c47

This was referenced Oct 19, 2023

feat: Create new table view in Rollouts dashboard #3097

Closed

chore: add labels to RolloutInfo api object response #3096

Closed

phclark added 2 commits October 19, 2023 09:01

simplify regex

9181c12

Signed-off-by: Philip Clark <[email protected]>

Merge branch 'phclark-feat/home-ui-refresh' of https://github.com/phc…

c40c1c9

…lark/argo-rollouts into phclark-feat/home-ui-refresh

make filters use OR logic

678cad8

Signed-off-by: Philip Clark <[email protected]>

phclark and others added 3 commits October 30, 2023 14:07

Merge branch 'master' into phclark-feat/home-ui-refresh

6732090

add keyboard listener

6869f5d

Signed-off-by: Philip Clark <[email protected]>

Merge branch 'phclark-feat/home-ui-refresh' of https://github.com/phc…

04044d1

…lark/argo-rollouts into phclark-feat/home-ui-refresh

zachaller added this to the v1.7 milestone Nov 1, 2023

zachaller assigned ashutosh16 Nov 2, 2023

set default display mode to grid

65d2812

Signed-off-by: Philip Clark <[email protected]>

ashutosh16 reviewed Nov 10, 2023

View reviewed changes

phclark added 7 commits November 14, 2023 13:07

set strategy column to left justify

c30e7a1

Signed-off-by: Philip Clark <[email protected]>

add tooltips to view buttons

d8cb10a

Signed-off-by: Philip Clark <[email protected]>

consider unknown status rollouts as needing attention

9404e35

Signed-off-by: Philip Clark <[email protected]>

remove duplicate escape key listener

ff17b55

Signed-off-by: Philip Clark <[email protected]>

group status filters together

04f5391

Signed-off-by: Philip Clark <[email protected]>

improve filter logic

4bae584

Signed-off-by: Philip Clark <[email protected]>

remove debug logging

9b5cd46

Signed-off-by: Philip Clark <[email protected]>

phclark added 2 commits November 14, 2023 17:14

dont show help on escape

530b942

Signed-off-by: Philip Clark <[email protected]>

properly remove url search params when disabled

6716d50

Signed-off-by: Philip Clark <[email protected]>

ashutosh16 reviewed Nov 16, 2023

View reviewed changes

phclark added 2 commits November 16, 2023 21:22

rename to RolloutGridWidget

bd848c9

Signed-off-by: Philip Clark <[email protected]>

prevent help menu from loading while searching

c93191d

Signed-off-by: Philip Clark <[email protected]>

ashutosh16 approved these changes Nov 28, 2023

View reviewed changes

zachaller approved these changes Nov 30, 2023

View reviewed changes

zachaller merged commit 8cae284 into argoproj:master Nov 30, 2023
24 checks passed

zachaller mentioned this pull request Dec 28, 2023

Argo Rollouts 1.6.0 UI Comments #3051

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Rollouts UI List view refresh #3118

feat: Rollouts UI List view refresh #3118

phclark commented Oct 19, 2023 •

edited by zachaller

Loading

github-actions bot commented Oct 19, 2023 •

edited

Loading

codecov bot commented Oct 19, 2023 •

edited

Loading

github-actions bot commented Oct 19, 2023 •

edited

Loading

phclark commented Oct 23, 2023

zachaller commented Oct 28, 2023

ashutosh16 commented Nov 2, 2023

phclark commented Nov 8, 2023

ashutosh16 commented Nov 10, 2023 •

edited

Loading

ashutosh16 Nov 10, 2023

ashutosh16 Nov 10, 2023 •

edited

Loading

phclark Nov 14, 2023

phclark Nov 15, 2023

ashutosh16 Nov 16, 2023

phclark Nov 27, 2023

ashutosh16 Nov 28, 2023

sonarcloud bot commented Nov 17, 2023

ashutosh16 left a comment

ashutosh16 commented Nov 28, 2023

zachaller left a comment

feat: Rollouts UI List view refresh #3118

feat: Rollouts UI List view refresh #3118

Conversation

phclark commented Oct 19, 2023 • edited by zachaller Loading

github-actions bot commented Oct 19, 2023 • edited Loading

Go Published Test Results

codecov bot commented Oct 19, 2023 • edited Loading

Codecov Report

github-actions bot commented Oct 19, 2023 • edited Loading

E2E Tests Published Test Results

phclark commented Oct 23, 2023

zachaller commented Oct 28, 2023

ashutosh16 commented Nov 2, 2023

phclark commented Nov 8, 2023

ashutosh16 commented Nov 10, 2023 • edited Loading

ashutosh16 Nov 10, 2023

Choose a reason for hiding this comment

ashutosh16 Nov 10, 2023 • edited Loading

Choose a reason for hiding this comment

phclark Nov 14, 2023

Choose a reason for hiding this comment

phclark Nov 15, 2023

Choose a reason for hiding this comment

ashutosh16 Nov 16, 2023

Choose a reason for hiding this comment

phclark Nov 27, 2023

Choose a reason for hiding this comment

ashutosh16 Nov 28, 2023

Choose a reason for hiding this comment

sonarcloud bot commented Nov 17, 2023

ashutosh16 left a comment

Choose a reason for hiding this comment

ashutosh16 commented Nov 28, 2023

zachaller left a comment

Choose a reason for hiding this comment

phclark commented Oct 19, 2023 •

edited by zachaller

Loading

github-actions bot commented Oct 19, 2023 •

edited

Loading

codecov bot commented Oct 19, 2023 •

edited

Loading

github-actions bot commented Oct 19, 2023 •

edited

Loading

ashutosh16 commented Nov 10, 2023 •

edited

Loading

ashutosh16 Nov 10, 2023 •

edited

Loading