-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Bump k8s dependencies to v1.26.11 #3211
Conversation
This was attempted back here, but it ran into the same k8s api type changes: #2828 |
efa4df2
to
2af3430
Compare
This addresses a few CVEs, but was slightly challenging because of some Kubernetes API changes. In particular, the Ingress type signatures changed. This required some surgery on a function that wrapped the extensionsv1beta1 Ingress and v1 Ingress types, attempting to provide some compatibility. The API changes were kind of tough to deal with, but fortunately the only field required by anything else in this project was the Hostname field, so I changed the function to just normalize the hostnames into a slice. Signed-off-by: Dan Lorenc <[email protected]>
93b840e
to
54c4880
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3211 +/- ##
==========================================
- Coverage 81.81% 81.81% -0.01%
==========================================
Files 135 135
Lines 20621 20625 +4
==========================================
+ Hits 16871 16874 +3
Misses 2880 2880
- Partials 870 871 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Dan Lorenc <[email protected]>
This is great, I did make a few changes to finish bumping the replace deps which fixed a few more tests but now it looks like manifest generation has some incompatibilities as well. |
Thanks! I'm a bit out of my depth now, not sure how to debug these failures. |
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
Signed-off-by: Zach Aller <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Amazing work!!! |
Thanks for contributing, was really helpful to have you go through and figure out all the logic required for this upgrade. |
Thanks a lot for getting it across the line! |
* Bump k8s dependencies to v1.26.0. This addresses a few CVEs, but was slightly challenging because of some Kubernetes API changes. In particular, the Ingress type signatures changed. This required some surgery on a function that wrapped the extensionsv1beta1 Ingress and v1 Ingress types, attempting to provide some compatibility. The API changes were kind of tough to deal with, but fortunately the only field required by anything else in this project was the Hostname field, so I changed the function to just normalize the hostnames into a slice. Signed-off-by: Dan Lorenc <[email protected]> * Update codegen. Signed-off-by: Dan Lorenc <[email protected]> * bump the replace deps, and re-run codegen Signed-off-by: Zach Aller <[email protected]> * bump to 0.26.11 and possible fix for new crd properties Signed-off-by: Zach Aller <[email protected]> * remove local changes Signed-off-by: Zach Aller <[email protected]> * switch alb test off of extensions and on to v1 Signed-off-by: Zach Aller <[email protected]> --------- Signed-off-by: Dan Lorenc <[email protected]> Signed-off-by: Zach Aller <[email protected]> Co-authored-by: Zach Aller <[email protected]> Signed-off-by: ashutosh16 <[email protected]>
* Bump k8s dependencies to v1.26.0. This addresses a few CVEs, but was slightly challenging because of some Kubernetes API changes. In particular, the Ingress type signatures changed. This required some surgery on a function that wrapped the extensionsv1beta1 Ingress and v1 Ingress types, attempting to provide some compatibility. The API changes were kind of tough to deal with, but fortunately the only field required by anything else in this project was the Hostname field, so I changed the function to just normalize the hostnames into a slice. Signed-off-by: Dan Lorenc <[email protected]> * Update codegen. Signed-off-by: Dan Lorenc <[email protected]> * bump the replace deps, and re-run codegen Signed-off-by: Zach Aller <[email protected]> * bump to 0.26.11 and possible fix for new crd properties Signed-off-by: Zach Aller <[email protected]> * remove local changes Signed-off-by: Zach Aller <[email protected]> * switch alb test off of extensions and on to v1 Signed-off-by: Zach Aller <[email protected]> --------- Signed-off-by: Dan Lorenc <[email protected]> Signed-off-by: Zach Aller <[email protected]> Co-authored-by: Zach Aller <[email protected]>
This addresses a few CVEs, but was slightly challenging because of some Kubernetes API changes.
In particular, the Ingress type signatures changed. This required some surgery on a function that wrapped the extensionsv1beta1 Ingress and v1 Ingress types, attempting to provide some compatibility.
The API changes were kind of tough to deal with, but fortunately the only field required by anything else in this project was the Hostname field, so I changed the function to just normalize the hostnames into a slice.
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.