-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix lint errors reported by golangci-lint #3458
Conversation
Signed-off-by: Chetan Banavikalmutt <[email protected]>
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3458 +/- ##
==========================================
+ Coverage 81.83% 82.81% +0.97%
==========================================
Files 135 135
Lines 20688 16998 -3690
==========================================
- Hits 16931 14077 -2854
+ Misses 2883 2034 -849
- Partials 874 887 +13 ☔ View full report in Codecov by Sentry. |
Go Published Test Results2 142 tests 2 142 ✅ 2m 51s ⏱️ Results for commit 8c1152c. |
E2E Tests Published Test Results 4 files 4 suites 3h 43m 27s ⏱️ For more details on these failures, see this check. Results for commit 8c1152c. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tests are passing, and append
s with no variadic function args are going to be a no-op.
This does not change the cli version: https://github.com/argoproj/argo-rollouts/blob/master/Dockerfile#L15 this will be bumped in a different PR |
Fix the lint errors reported when running
make lint
locally.Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.