Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix lint errors reported by golangci-lint #3458

Merged
merged 1 commit into from
Mar 29, 2024
Merged

chore: fix lint errors reported by golangci-lint #3458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion controller/metrics/prommetrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ var (
MetricAnalysisTemplateInfo = prometheus.NewDesc(
"analysis_template_info",
"Information about analysis templates.",
append(namespaceNameLabels),
namespaceNameLabels,
nil,
)

Expand Down
3 changes: 0 additions & 3 deletions rollout/canary_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,7 +957,6 @@ func TestRollBackToActiveReplicaSetWithinWindow(t *testing.T) {

f.kubeobjects = append(f.kubeobjects, rs1, rs2)
f.replicaSetLister = append(f.replicaSetLister, rs1, rs2)
f.serviceLister = append(f.serviceLister)

// Switch back to version 1
r2.Spec.Template = r1.Spec.Template
Expand Down Expand Up @@ -1654,8 +1653,6 @@ func TestCanaryRolloutWithInvalidPingServiceName(t *testing.T) {

f.rolloutLister = append(f.rolloutLister, r)
f.objects = append(f.objects, r)
f.kubeobjects = append(f.kubeobjects)
f.serviceLister = append(f.serviceLister)

patchIndex := f.expectPatchRolloutAction(r)
f.run(getKey(r, t))
Expand Down
1 change: 0 additions & 1 deletion rollout/service_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,6 @@ func TestPreviewServiceNotFound(t *testing.T) {
activeSvc := newService("active-svc", 80, nil, nil)
notUsedPreviewSvc := newService("preview-svc", 80, nil, nil)
f.kubeobjects = append(f.kubeobjects, activeSvc)
f.serviceLister = append(f.serviceLister)

patchIndex := f.expectPatchRolloutAction(r)
f.run(getKey(r, t))
Expand Down
Loading