Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webmetric): Support POST/PUT content with web metrics. Fixes #371 #1573

Merged
merged 7 commits into from
Nov 1, 2021

Conversation

noam-codefresh
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@codecov
Copy link

codecov bot commented Oct 10, 2021

Codecov Report

Merging #1573 (7f412df) into master (d83543a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1573   +/-   ##
=======================================
  Coverage   81.76%   81.77%           
=======================================
  Files         112      112           
  Lines       15120    15126    +6     
=======================================
+ Hits        12363    12369    +6     
  Misses       2110     2110           
  Partials      647      647           
Impacted Files Coverage Δ
metricproviders/webmetric/webmetric.go 67.22% <100.00%> (+1.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d83543a...7f412df. Read the comment docs.

@noam-codefresh noam-codefresh force-pushed the webmetric_post branch 2 times, most recently from 65a1231 to ed2e7cf Compare October 17, 2021 08:32
@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit fe87bdd into argoproj:master Nov 1, 2021
@noam-codefresh noam-codefresh deleted the webmetric_post branch November 2, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants