Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experiment): Added DryRun analysis mode functionality for experiments #1691

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

agrawroh
Copy link
Member

@agrawroh agrawroh commented Dec 8, 2021

Description

Thins PR extends the dryRun functionality to the experiments.
https://argoproj.github.io/argo-rollouts/features/analysis/#dry-run-mode

Checklist

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Rohit Agrawal [email protected]

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #1691 (5f83317) into master (4d3b992) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1691      +/-   ##
==========================================
- Coverage   82.07%   82.05%   -0.02%     
==========================================
  Files         116      116              
  Lines       16064    16030      -34     
==========================================
- Hits        13184    13154      -30     
+ Misses       2208     2205       -3     
+ Partials      672      671       -1     
Impacted Files Coverage Δ
utils/analysis/helpers.go 77.93% <ø> (-0.25%) ⬇️
experiments/experiment.go 89.69% <100.00%> (+0.04%) ⬆️
rollout/trafficrouting/istio/controller.go 50.81% <0.00%> (-1.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d3b992...5f83317. Read the comment docs.

@agrawroh agrawroh force-pushed the dry-run-mode-exp branch 4 times, most recently from 002b840 to 0841f09 Compare December 8, 2021 22:45
@sonarcloud
Copy link

sonarcloud bot commented Dec 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.1% 7.1% Duplication

Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jessesuen jessesuen merged commit 15096f3 into argoproj:master Dec 14, 2021
@agrawroh agrawroh removed the ready-for-review Ready for final review label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants