Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix flaky TestAbortRolloutAfterFailedExperiment test #1710

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

alexmt
Copy link
Contributor

@alexmt alexmt commented Dec 13, 2021

Signed-off-by: Alexander Matyushentsev [email protected]

PR fixes flackiness in TestAbortRolloutAfterFailedExperiment introduced by #1654

go test -run TestAbortRolloutAfterFailedExperiment github.com/argoproj/argo-rollouts/rollout  -count 100
ok  	github.com/argoproj/argo-rollouts/rollout	21.187s

@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #1710 (80e45f8) into master (b3d50d1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1710   +/-   ##
=======================================
  Coverage   82.06%   82.06%           
=======================================
  Files         116      116           
  Lines       16075    16075           
=======================================
  Hits        13192    13192           
  Misses       2210     2210           
  Partials      673      673           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3d50d1...80e45f8. Read the comment docs.

@alexmt alexmt merged commit 3c1e87c into master Dec 13, 2021
@zachaller zachaller deleted the flaky-experiment-test branch January 16, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants