fix: delay service injection of selector labels until ReplicaSet available #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1777 +/- ##
=======================================
Coverage 82.06% 82.07%
=======================================
Files 116 116
Lines 16264 16270 +6
=======================================
+ Hits 13347 13353 +6
Misses 2235 2235
Partials 682 682
Continue to review full report at Codecov.
|
jessesuen
force-pushed
the
fix-delay-stableinjection
branch
from
d5a4a6f
to
4623b7e
Compare
jessesuen
changed the title
…lable Signed-off-by: Jesse Suen <[email protected]>
Signed-off-by: Jesse Suen <[email protected]>
jessesuen
force-pushed
the
fix-delay-stableinjection
branch
from
e5043b3
to
a1ebaa4
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change delays the updating of the stable service selector unless the stable replicaset is
readyavailable. This helps ensure we don't prematurely point the stable service to nothing in the event we are taking over a Service in the migration case, potentially causing downtime.Resolves #1731
Signed-off-by: Jesse Suen [email protected]