Issue #1779: add MinReplicas option to SetCanaryScale #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1935 +/- ##
==========================================
+ Coverage 82.36% 82.39% +0.02%
==========================================
Files 119 119
Lines 16872 16919 +47
==========================================
+ Hits 13897 13940 +43
- Misses 2284 2286 +2
- Partials 691 693 +2
Continue to review full report at Codecov.
|
Fixes docs: Add SAP Concur Signed-off-by: Tomas Valasek [email protected] Signed-off-by: Shlomo Sanders <[email protected]>
…mental step. (argoproj#1863) feat: Dashboard now displaying name, specRef and weight in the experimental step. (argoproj#1863) Signed-off-by: Alexander Matyushentsev <[email protected]> Signed-off-by: Shlomo Sanders <[email protected]>
Signed-off-by: Ravi Hari <[email protected]> Signed-off-by: Shlomo Sanders <[email protected]>
Signed-off-by: Jesse Suen <[email protected]> Signed-off-by: Shlomo Sanders <[email protected]>
feat: Report notification metrics for rollouts (argoproj#1856) Signed-off-by: Ravi Hari <[email protected]> Signed-off-by: Shlomo Sanders <[email protected]>
Signed-off-by: Shlomo Sanders <[email protected]>
Signed-off-by: Shlomo Sanders <[email protected]>
Signed-off-by: Shlomo Sanders <[email protected]>
Signed-off-by: Shlomo Sanders <[email protected]>
ssanders1449
force-pushed
the
issue_1779
branch
from
6ee478d
to
ab7dd8c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hmm. It seems that the last force-push (to add the signoff) brought too many changes into the PR, I am going to redo the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1779
Adds an optional 'MinReplicas' field to SetCanaryScale
See #1779 for use cases