Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update ro.Status.ALB when first creating rollout object #1986

Merged
merged 15 commits into from
Jul 22, 2022
Merged

fix: Update ro.Status.ALB when first creating rollout object #1986

merged 15 commits into from
Jul 22, 2022

Commits on Jun 24, 2022

  1. fix: make sure we update rollout.Status.ALB when first create Rollout… 

    … object

This fixes the case when we first create a rollout the status.ALB field does not
get updated with valid information form the elb.

Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    ba9c501 View commit details
    Browse the repository at this point in the history

  2. Refactor check for if we should verify alb. 

    This creates a new rolloututil function ShouldVerifyWeight that verifies
that we should call aws because the rollout is in the middle of some update.

The reason I feel this should move into the ingress implmentation function VerifyWeight
is becuase in the future other ingresses might also need to verify weights and adding
ingress specific status checks in trafficrouting.go like a leak details where it should be
up to the ingress provider to determin if it should be careful of rate limiting do to say it
being a cloud provider call.

Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    02f04b1 View commit details
    Browse the repository at this point in the history

  3. lint 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    b75638e View commit details
    Browse the repository at this point in the history

  4. Fix tests 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    08aaba4 View commit details
    Browse the repository at this point in the history

  5. Add new test for ShouldVerifyWeight 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    a71a581 View commit details
    Browse the repository at this point in the history

  6. Fix logic 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    8180ad4 View commit details
    Browse the repository at this point in the history

  7. Add test for where we do not need to verify weight and its already set 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    9f5d1b8 View commit details
    Browse the repository at this point in the history

  8. fix up review comments 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    0677680 View commit details
    Browse the repository at this point in the history

  9. fix tests 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    ed2e177 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2022

  1. Merge branch 'master' of https://github.com/argoproj/argo-rollouts in… 

    …to fix-alb-ro-status-update

Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    a3305ce View commit details
    Browse the repository at this point in the history

  2. fix bad merge 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    21c2cfd View commit details
    Browse the repository at this point in the history

  3. Fix test 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    fae4645 View commit details
    Browse the repository at this point in the history

  4. Fix test 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    f2ce51f View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2022

  1. Clearer function name 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    a1735a8 View commit details
    Browse the repository at this point in the history

  2. Clean up if logic 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    c1cd376 View commit details
    Browse the repository at this point in the history