Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Kustomize 4.5.5 remote OpenAPI data functionality #2176

Closed
wants to merge 1 commit into from

Conversation

KENNYSOFT
Copy link

@KENNYSOFT KENNYSOFT commented Aug 4, 2022

Ref: kubernetes-sigs/kustomize#4567

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #2176 (e0e08d8) into master (69fd80c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2176   +/-   ##
=======================================
  Coverage   82.37%   82.37%           
=======================================
  Files         121      121           
  Lines       18069    18069           
=======================================
  Hits        14884    14884           
  Misses       2416     2416           
  Partials      769      769           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

Go Published Test Results

1 731 tests   1 731 ✔️  2m 33s ⏱️
   101 suites         0 💤
       1 files           0

Results for commit e0e08d8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

E2E Tests Published Test Results

  1 files    1 suites   48m 3s ⏱️
88 tests 83 ✔️ 3 💤 2
90 runs  85 ✔️ 3 💤 2

For more details on these failures, see this check.

Results for commit e0e08d8.

♻️ This comment has been updated with latest results.

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@zachaller
Copy link
Collaborator

Thanks for the PR we actually recently added a new way we generate schema files you can read about on the blog here. This PR also updates to use the new file #2216

@zachaller zachaller closed this Aug 30, 2022
@KENNYSOFT
Copy link
Author

@zachaller I see, but shouldn't we specify that the user must use Kustomize 4.5.5+ to use OpenAPI data from a remote resource?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants