Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix minor mistakes in Migrating to Deployments #2270

Merged
merged 1 commit into from
Jun 15, 2023
Merged

docs: fix minor mistakes in Migrating to Deployments #2270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions docs/migrating.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,11 @@ spec:
## Reference Deployment From Rollout
Instead of removing Deployment you can scale-down in to zero and reference from the Rollout resource:
Instead of removing Deployment you can scale it down to zero and reference it from the Rollout resource:
1. Create a Rollout resource.
1. Reference an existing Deployment using `workloadRef` field.
1. Scale-down existing Deployment by changing `replicas` field of an existing Deployment to zero.
1. Scale-down an existing Deployment by changing `replicas` field of an existing Deployment to zero.
1. To perform an update, the change should be made to the Pod template field of the Deployment.

Below is an example of a Rollout resource referencing a Deployment.
Expand Down Expand Up @@ -150,7 +150,8 @@ When converting a Rollout to a Deployment, it involves changing three fields:

When a rollout is referencing to a deployment:

1. Scale-up the Deployment by changing `replicas` field of an existing Rollout to zero.
1. Scale-down existing Rollout by changing `replicas` field of an existing Rollout to zero.
1. Scale-up an existing Deployment by changing its `replicas` field to a desired number of pods.
1. Wait for the Deployment pods to become Ready.
1. Scale-down an existing Rollout by changing its `replicas` field to zero.

Please refer to [Running Rollout and Deployment side-by-side](#running-rollout-and-deployment-side-by-side) and [Traffic Management During Migration](#traffic-management-during-migration) for caveats.