Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:(controller) leader election bug #2280

Closed
wants to merge 17 commits into from
Closed

fix:(controller) leader election bug #2280

wants to merge 17 commits into from

Commits on Sep 30, 2022

  1. WIP on fixing leader election fix 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    7a7355b View commit details
    Browse the repository at this point in the history

  2. Start and stop informers as well 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    5ae8779 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2022

  1. lint 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    5c0a54d View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. Remove tests that do not test anything 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    306661a View commit details
    Browse the repository at this point in the history

  2. fix lint 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    bc6c327 View commit details
    Browse the repository at this point in the history

  3. github trigger re-run 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    b2cfe86 View commit details
    Browse the repository at this point in the history

  4. Cleanup 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    00b7699 View commit details
    Browse the repository at this point in the history

  5. cleanup 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    28fba55 View commit details
    Browse the repository at this point in the history

  6. Add back one test 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    809b652 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. remove secondary metric server 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    8d516fe View commit details
    Browse the repository at this point in the history

  2. Remove secondary metric test 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    541123d View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. Add single instance test to catch log lines 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    593af56 View commit details
    Browse the repository at this point in the history

  2. We should shutdown if we can not sync 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    76d5134 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of https://github.com/argoproj/argo-rollouts in… 

    …to fix-leader-election-bug
    @zachaller
    zachaller committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    5667c3f View commit details
    Browse the repository at this point in the history

  4. fix lint 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    72c4697 View commit details
    Browse the repository at this point in the history

  5. Redo for loop will have another pr that stops via context 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    0838b65 View commit details
    Browse the repository at this point in the history

  6. Fix comment 

    Signed-off-by: zachaller <[email protected]>
    @zachaller
    zachaller committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    c369d1c View commit details
    Browse the repository at this point in the history