Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webmetrics): Support jsonBody for web metric provider Fixes #2275 #2301

Closed
wants to merge 4 commits into from

Conversation

premadk
Copy link
Contributor

@premadk premadk commented Oct 7, 2022

Signed-off-by: Prema devi Kuppuswamy [email protected]

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

Go Published Test Results

1 772 tests   1 772 ✔️  2m 34s ⏱️
   101 suites         0 💤
       1 files           0

Results for commit 0c61098.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Base: 82.38% // Head: 82.37% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (0c61098) compared to base (1394f4e).
Patch coverage: 84.21% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2301      +/-   ##
==========================================
- Coverage   82.38%   82.37%   -0.01%     
==========================================
  Files         121      121              
  Lines       18476    18490      +14     
==========================================
+ Hits        15221    15232      +11     
- Misses       2468     2470       +2     
- Partials      787      788       +1     
Impacted Files Coverage Δ
metricproviders/webmetric/webmetric.go 68.88% <84.21%> (+1.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

E2E Tests Published Test Results

89 tests   86 ✔️  45m 57s ⏱️
  1 suites    3 💤
  1 files      0

Results for commit 0c61098.

♻️ This comment has been updated with latest results.

@zachaller zachaller self-requested a review October 8, 2022 02:49
@zachaller zachaller added this to the v1.4 milestone Oct 8, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@premadk premadk closed this Oct 11, 2022
@premadk
Copy link
Contributor Author

premadk commented Oct 11, 2022

opened new pr: #2312

@zachaller zachaller removed this from the v1.4 milestone Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants