Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move zachaller to approvers #2311

Merged
merged 1 commit into from
Oct 16, 2022

Conversation

zachaller
Copy link
Collaborator

Signed-off-by: zachaller [email protected]

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.9% 2.9% Duplication

@zachaller zachaller marked this pull request as ready for review October 11, 2022 14:50
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Base: 82.38% // Head: 82.38% // No change to project coverage 👍

Coverage data is based on head (3c92f41) compared to base (1394f4e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2311   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         121      121           
  Lines       18476    18476           
=======================================
  Hits        15221    15221           
  Misses       2468     2468           
  Partials      787      787           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Go Published Test Results

1 772 tests   1 772 ✔️  2m 33s ⏱️
   101 suites         0 💤
       1 files           0

Results for commit 3c92f41.

@github-actions
Copy link
Contributor

E2E Tests Published Test Results

  1 files    1 suites   50m 35s ⏱️
89 tests 81 ✔️ 3 💤 5
95 runs  87 ✔️ 3 💤 5

For more details on these failures, see this check.

Results for commit 3c92f41.

Copy link
Contributor

@mayzhang2000 mayzhang2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mayzhang2000 mayzhang2000 merged commit 0094b15 into argoproj:master Oct 16, 2022
jenciso pushed a commit to jenciso/argo-rollouts that referenced this pull request Oct 25, 2022
Signed-off-by: zachaller <[email protected]>

Signed-off-by: zachaller <[email protected]>
@zachaller zachaller changed the title Move zachaller to approvers chore: Move zachaller to approvers Nov 8, 2022
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 8, 2022
Signed-off-by: zachaller <[email protected]>

Signed-off-by: zachaller <[email protected]>
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 26, 2022
Signed-off-by: zachaller <[email protected]>

Signed-off-by: zachaller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants