Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: correct the case that autoPromotionSeconds feature is ignored #2388

Merged
merged 13 commits into from
Jul 11, 2024
Merged

docs: correct the case that autoPromotionSeconds feature is ignored #2388

merged 13 commits into from
Jul 11, 2024

Conversation

itsme2980
Copy link
Contributor

@itsme2980 itsme2980 commented Nov 2, 2022 •
edited
Loading

Description:

The AutoPromotionSeconds is ignored when the AutoPromotionEnabled field is set to false

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022 •
edited
Loading

Go Published Test Results

2 164 tests   2 164 ✅  2m 54s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit 74f3e00.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Nov 2, 2022 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.27%. Comparing base (7188d99) to head (74f3e00).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2388      +/-   ##
==========================================
+ Coverage   80.25%   80.27%   +0.01%     
==========================================
  Files         156      156              
  Lines       17966    17964       -2     
==========================================
+ Hits        14419    14420       +1     
+ Misses       2634     2631       -3     
  Partials      913      913

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022 •
edited
Loading

E2E Tests Published Test Results

  4 files    4 suites   3h 27m 0s ⏱️
111 tests 100 ✅  6 💤  5 ❌
456 runs  421 ✅ 24 💤 11 ❌

For more details on these failures, see this check.

Results for commit 74f3e00.

♻️ This comment has been updated with latest results.

iam-veeramalla
iam-veeramalla approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@iam-veeramalla iam-veeramalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itsme2980 itsme2980 force-pushed the master branch 2 times, most recently from 29bcb9b to 46f95a1 Compare November 3, 2022 07:37
dependabot bot and others added 6 commits November 3, 2022 14:39
@dependabot
chore(deps): bump actions/upload-artifact from 2 to 3 (argoproj#1973)
f606cb3 
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2 to 3.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v2...v3)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: toann <[email protected]>
@34fathombelow
chore: sign container images and checksum assets (argoproj#2334)
80f09c7 
Signed-off-by: Justin Marquis <[email protected]>
Signed-off-by: toann <[email protected]>
@zachaller
chore(deps): upgrade ui deps to fix high security cve's (argoproj#2345)
de85841 
* ui: upgrade deps to fix high security cve's

Signed-off-by: zachaller <[email protected]>

* github trigger re-run

Signed-off-by: zachaller <[email protected]>

Signed-off-by: zachaller <[email protected]>
Signed-off-by: toann <[email protected]>
@dependabot
chore(deps): bump imjasonh/setup-crane from 0.1 to 0.2 (argoproj#2387)
b859c96 
Bumps [imjasonh/setup-crane](https://github.com/imjasonh/setup-crane) from 0.1 to 0.2.
- [Release notes](https://github.com/imjasonh/setup-crane/releases)
- [Commits](imjasonh/setup-crane@v0.1...v0.2)

---
updated-dependencies:
- dependency-name: imjasonh/setup-crane
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: toann <[email protected]>
docs: Fix the case that autoPromotionSeconds feature is ignored
dc34d08 
Signed-off-by: Toan Nguyen <[email protected]>

Signed-off-by: toann <[email protected]>
@dependabot
chore(deps): bump dependabot/fetch-metadata from 1.3.4 to 1.3.5 (argo…
30de7fe 
…proj#2390)

Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 1.3.4 to 1.3.5.
- [Release notes](https://github.com/dependabot/fetch-metadata/releases)
- [Commits](dependabot/fetch-metadata@v1.3.4...v1.3.5)

---
updated-dependencies:
- dependency-name: dependabot/fetch-metadata
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: toann <[email protected]>
@itsme2980
Copy link
Contributor Author

Hi @iam-veeramalla , thanks for looking at this. Could I ask someone for approval in order to make this PR able to be merged. It helps the Argo Rollout users avoid confusion when following this document for the first time integrating with Argo Rollout.

@iam-veeramalla
Copy link
Member

Hi @iam-veeramalla , thanks for looking at this. Could I ask someone for approval in order to make this PR able to be merged. It helps the Argo Rollout users avoid confusion when following this document for the first time integrating with Argo Rollout.

We can request @leoluz @harikrongali

@sonarcloud
Copy link

sonarcloud bot commented Nov 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

agrawroh
agrawroh approved these changes Dec 30, 2022
View reviewed changes
Copy link
Member

@agrawroh agrawroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a little bit more clarification since we are at it :)

@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

This PR is stale because it has been open 90 days with no activity.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

This PR is stale because it has been open 90 days with no activity.

@zachaller zachaller closed this Jun 17, 2024
@zachaller zachaller reopened this Jun 17, 2024
@agrawroh
Copy link
Member

agrawroh commented Jul 3, 2024

@zachaller Could you help merge this?

@zachaller zachaller merged commit fdcb0d8 into argoproj:master Jul 11, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachaller zachaller zachaller approved these changes

@agrawroh agrawroh agrawroh approved these changes

@iam-veeramalla iam-veeramalla iam-veeramalla approved these changes

@httin httin httin approved these changes

Assignees
No one assigned
Labels
no-pr-activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@itsme2980 @iam-veeramalla @agrawroh @zachaller @httin @34fathombelow