Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(controller): don't hardcode experiment ports; always create service #2397

Merged
merged 37 commits into from
Nov 8, 2022
Merged

feat(controller): don't hardcode experiment ports; always create service #2397

merged 37 commits into from
Nov 8, 2022

Commits on Oct 21, 2022

  1. Copy ports from replicaset rather than hardcoding them 

        Fixes: argoproj#2233

Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    952d043 View commit details
    Browse the repository at this point in the history

  2. Allow user to set the experiment service name. 

    Create a service even though a weight is not set (when the name is provided)

Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    69e9061 View commit details
    Browse the repository at this point in the history

  3. Run codegen 

    Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    d6ae5ad View commit details
    Browse the repository at this point in the history

  4. Run codegen again, service name is optional 

    Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    666d888 View commit details
    Browse the repository at this point in the history

  5. Fix conversion and tests 

    Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    431f894 View commit details
    Browse the repository at this point in the history

  6. Fix codegen 

    Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    49b01f1 View commit details
    Browse the repository at this point in the history

  7. Fix codegen again 

    Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    21adb4a View commit details
    Browse the repository at this point in the history

  8. white space 

    Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    f534f9c View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2022

  1. Extend from corev1.ServiceSpec 

    Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    2b22947 View commit details
    Browse the repository at this point in the history

  2. make lint 

    Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    0f28e2b View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2022

  1. Merge branch 'master' into experiment-service-name

    @alexef
    alexef authored Oct 23, 2022
    Configuration menu
    Copy the full SHA
    6525b3f View commit details
    Browse the repository at this point in the history

  2. infer ports from ReplicaSet. this should fix e2e tests 

    Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    d805441 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/experiment-service-name' into ex… 

    …periment-service-name
    @alexef
    alexef committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    5b66607 View commit details
    Browse the repository at this point in the history

  4. fix e2e 

    disable service where service is not needed or expected
set ports where service must be created

Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    303b29e View commit details
    Browse the repository at this point in the history

  5. use json inline so that crd reflects ports 

    Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    d1371cd View commit details
    Browse the repository at this point in the history

  6. Add codegen openapi_generated.go 

    Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    e1247e1 View commit details
    Browse the repository at this point in the history

  7. fix codegen, protobuf is needed 

    Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Oct 23, 2022
    Configuration menu
    Copy the full SHA
    b8c4157 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Merge branch 'master' into experiment-service-name

    @alexef
    alexef authored Oct 24, 2022
    Configuration menu
    Copy the full SHA
    8c671cc View commit details
    Browse the repository at this point in the history

  2. Add unit test 

    Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    de6b858 View commit details
    Browse the repository at this point in the history

  3. Add unit test to new not tested code - copy pods from RS 

    Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    bc379f7 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. Merge branch 'master' into experiment-service-name

    @alexef
    alexef authored Oct 31, 2022
    Configuration menu
    Copy the full SHA
    9437f6d View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. Merge branch 'master' into experiment-service-name

    @alexef
    alexef authored Nov 1, 2022
    Configuration menu
    Copy the full SHA
    9a179d4 View commit details
    Browse the repository at this point in the history

  2. Address PR comment: set entire spec 

    Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    c32cbe7 View commit details
    Browse the repository at this point in the history

  3. docs: update experiment and rollout spec 

    Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    0f5ed7a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into experiment-service-name

    @alexef
    alexef authored Nov 1, 2022
    Configuration menu
    Copy the full SHA
    8f46d8c View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. Merge branch 'master' into experiment-service-name

    @alexef
    alexef authored Nov 3, 2022
    Configuration menu
    Copy the full SHA
    95b48ca View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. redo pr. drop spec changes. only inherit ports and always create the … 

    …service. update docs

Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    09ac6e1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into experiment-ports

    @alexef
    alexef authored Nov 4, 2022
    Configuration menu
    Copy the full SHA
    9e77224 View commit details
    Browse the repository at this point in the history

  3. Ran go fmt 

    Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    b262cd1 View commit details
    Browse the repository at this point in the history

  4. revert changes. only enable service if weighted or template service n… 

    …ot nil

Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    fcbb31a View commit details
    Browse the repository at this point in the history

  5. typo in types 

    Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    0c1984d View commit details
    Browse the repository at this point in the history

  6. go fmt. need pre-commit hook 

    Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    2a073c5 View commit details
    Browse the repository at this point in the history

  7. no more spec changes 

    Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    9d2ce03 View commit details
    Browse the repository at this point in the history

  8. drop test which is not relevant any more 

    Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    80eea63 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into experiment-ports

    @alexef
    alexef authored Nov 4, 2022
    Configuration menu
    Copy the full SHA
    4a1fa58 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2022

  1. fix e2e - only generate service if RS has ports 

    Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    8771a96 View commit details
    Browse the repository at this point in the history

  2. fix e2e 

    Signed-off-by: Alex Eftimie <[email protected]>
    @alexef
    alexef committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    31cf3d5 View commit details
    Browse the repository at this point in the history