Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Apache APISIX support. Fixes #2395 #2436

Closed
wants to merge 20 commits into from
Closed

feat: Apache APISIX support. Fixes #2395 #2436

wants to merge 20 commits into from

Conversation

Gallardot
Copy link
Contributor

Fixes #2395

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Gallardot and others added 20 commits November 27, 2022 23:19
@Gallardot
feat: Apisix support
911cf05 
Signed-off-by: Gallardot <[email protected]>
@danielhelfand @zachaller @Gallardot
chore: remove deprecated -i for go build (argoproj#2047)
3689fe6 
Signed-off-by: Daniel Helfand <[email protected]>

Signed-off-by: Daniel Helfand <[email protected]>
Signed-off-by: zachaller <[email protected]>
Co-authored-by: zachaller <[email protected]>
Signed-off-by: Gallardot <[email protected]>
@dependabot @Gallardot
chore(deps): bump github.com/aws/aws-sdk-go-v2/service/cloudwatch (ar…
a865473 
…goproj#2404)

Bumps [github.com/aws/aws-sdk-go-v2/service/cloudwatch](https://github.com/aws/aws-sdk-go-v2) from 1.21.8 to 1.21.9.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@service/eks/v1.21.8...service/eks/v1.21.9)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/cloudwatch
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Gallardot <[email protected]>
@tukak @Gallardot
Add Productboard to USERS.md (argoproj#2408)
9a4d19a 
Signed-off-by: tukak <[email protected]>
Signed-off-by: Gallardot <[email protected]>
@dependabot @Gallardot
chore(deps): bump github.com/aws/aws-sdk-go-v2/service/elasticloadbal…
0d582bb 
…ancingv2 (argoproj#2406)

Bumps [github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2](https://github.com/aws/aws-sdk-go-v2) from 1.18.22 to 1.18.23.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@service/ecs/v1.18.22...service/ecs/v1.18.23)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Gallardot <[email protected]>
@dependabot @Gallardot
chore(deps): bump github.com/aws/aws-sdk-go-v2/config (argoproj#2409)
ed18629 
Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.17.10 to 1.18.0.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@config/v1.17.10...config/v1.18.0)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Gallardot <[email protected]>
@tukak @Gallardot
fix: add patch verb to deployment resource (argoproj#2407)
92cc4ac 
* Add patch verb to deployment resource

Dashboard fails with ```failed restoring revision 21: deployments.apps "ourapp" is forbidden: User "system:serviceaccount:argo-rollouts:argo-rollouts-dashboard" cannot patch resource "deployments" in API group "apps" in the namespace "ournamespace"``` when trying to rollback `Rollout` defined using existing `Deployment` and `workloadRef` config.
Adding `patch` verb for `deployments` should fix it.

Signed-off-by: tukak <[email protected]>

* Generate dashboard-manifest.yaml
Signed-off-by: tukak <[email protected]>

Signed-off-by: tukak <[email protected]>
Signed-off-by: Gallardot <[email protected]>
@dependabot @Gallardot
chore(deps): bump github.com/aws/aws-sdk-go-v2/service/elasticloadbal…
4e1671d 
…ancingv2 (argoproj#2412)

Bumps [github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2](https://github.com/aws/aws-sdk-go-v2) from 1.18.23 to 1.18.24.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@service/ecs/v1.18.23...service/ecs/v1.18.24)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Gallardot <[email protected]>
@dependabot @Gallardot
chore(deps): bump github.com/aws/aws-sdk-go-v2/config (argoproj#2413)
ffaacca 
Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.18.0 to 1.18.1.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@config/v1.18.0...config/v1.18.1)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Gallardot <[email protected]>
@dependabot @Gallardot
chore(deps): bump github.com/aws/aws-sdk-go-v2/service/cloudwatch (ar…
93da355 
…goproj#2414)

Bumps [github.com/aws/aws-sdk-go-v2/service/cloudwatch](https://github.com/aws/aws-sdk-go-v2) from 1.21.9 to 1.21.10.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@service/eks/v1.21.9...service/eks/v1.21.10)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/cloudwatch
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Gallardot <[email protected]>
@thedevelopnik @Gallardot
fix ambassador-edge-stack flag with correct api (argoproj#2416)
bd04c69 
Signed-off-by: Dave Sudia <[email protected]>

Signed-off-by: Dave Sudia <[email protected]>
Signed-off-by: Gallardot <[email protected]>
@dependabot @Gallardot
chore(deps): bump github.com/aws/aws-sdk-go-v2/service/elasticloadbal…
c515a38 
…ancingv2 (argoproj#2417)

Bumps [github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2](https://github.com/aws/aws-sdk-go-v2) from 1.18.24 to 1.18.25.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@service/ecs/v1.18.24...service/ecs/v1.18.25)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Gallardot <[email protected]>
@dependabot @Gallardot
chore(deps): bump github.com/aws/aws-sdk-go-v2/config (argoproj#2418)
1769c06 
Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.18.1 to 1.18.2.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@config/v1.18.1...config/v1.18.2)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Gallardot <[email protected]>
@gpkc @Gallardot
Update canary.md (argoproj#2358)
e0bf873 
Signed-off-by: Guilherme Caminha <[email protected]>

Signed-off-by: Guilherme Caminha <[email protected]>
Signed-off-by: Gallardot <[email protected]>
@dependabot @Gallardot
chore(deps): bump google.golang.org/grpc from 1.50.1 to 1.51.0 (argop…
7f4a126 
…roj#2421)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.50.1 to 1.51.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.50.1...v1.51.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Gallardot <[email protected]>
@kostis-codefresh @Gallardot
docs: Explain upgrade process (argoproj#2424)
a1e052a 
Signed-off-by: Kostis Kapelonis <[email protected]>

Signed-off-by: Kostis Kapelonis <[email protected]>
Signed-off-by: Gallardot <[email protected]>
@dependabot @Gallardot
chore(deps): bump github.com/aws/aws-sdk-go-v2/service/elasticloadbal…
25d69bf 
…ancingv2 (argoproj#2428)

Bumps [github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2](https://github.com/aws/aws-sdk-go-v2) from 1.18.25 to 1.18.26.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@service/ecs/v1.18.25...service/ecs/v1.18.26)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Gallardot <[email protected]>
@dependabot @Gallardot
chore(deps): bump github.com/aws/aws-sdk-go-v2/config (argoproj#2429)
5c0cea3 
Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.18.2 to 1.18.3.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@config/v1.18.2...config/v1.18.3)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Gallardot <[email protected]>
@dependabot @Gallardot
chore(deps): bump github.com/aws/aws-sdk-go-v2/service/cloudwatch (ar…
728bbe9 
…goproj#2430)

Bumps [github.com/aws/aws-sdk-go-v2/service/cloudwatch](https://github.com/aws/aws-sdk-go-v2) from 1.21.10 to 1.21.11.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@service/eks/v1.21.10...service/eks/v1.21.11)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/cloudwatch
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Gallardot <[email protected]>
@Gallardot
chore: merge master
a7cb37e 
Signed-off-by: Gallardot <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Nov 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Base: 81.55% // Head: 81.46% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (1e71270) compared to base (93c2520).
Patch coverage: 72.41% of modified lines in pull request are covered.

❗ Current head 1e71270 differs from pull request most recent head a7cb37e. Consider uploading reports for the commit a7cb37e to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2436      +/-   ##
==========================================
- Coverage   81.55%   81.46%   -0.09%     
==========================================
  Files         124      125       +1     
  Lines       18931    19103     +172     
==========================================
+ Hits        15439    15563     +124     
- Misses       2702     2736      +34     
- Partials      790      804      +14
Impacted Files Coverage Δ
rollout/trafficrouting.go 73.20% <0.00%> (-2.28%) ⬇️
utils/defaults/defaults.go 89.10% <ø> (ø)
rollout/trafficrouting/apisix/apisix.go 70.58% <70.58%> (ø)
rollout/bluegreen.go 68.30% <100.00%> (ø)
rollout/canary.go 75.48% <100.00%> (ø)
rollout/sync.go 80.13% <100.00%> (+0.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Gallardot Gallardot closed this Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apache APISIX support
6 participants
@Gallardot @danielhelfand @tukak @thedevelopnik @gpkc @kostis-codefresh