fix: When Degraded state, canary-service doesn't have any endpoints

[idurgakalyan]

When Degraded state, canary-service doesn't have any endpoints resulting in traefik unable to route requests in failed state.

Signed-off-by: Kalyan Inampudi [email protected]

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
• The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
• I've signed my commits with DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My builds are green. Try syncing with master if they are not.
• My organization is added to USERS.md.

[github-actions]

Go Published Test Results

1 834 tests   1 834 ✔️  2m 30s ⏱️
   105 suites         0 💤
       1 files           0 ❌

Results for commit 6aebcf2.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

Base: 81.69% // Head: 81.64% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (6aebcf2) compared to base (3c2cef9).
Patch coverage: 32.25% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2536      +/-   ##
==========================================
- Coverage   81.69%   81.64%   -0.06%     
==========================================
  Files         126      126              
  Lines       19136    19156      +20     
==========================================
+ Hits        15634    15639       +5     
- Misses       2709     2721      +12     
- Partials      793      796       +3     

Impacted Files	Coverage Δ
rollout/canary.go	74.93% <25.00%> (-0.56%)	⬇️
metricproviders/prometheus/prometheus.go	89.43% <30.76%> (-7.00%)	⬇️
rollout/service.go	78.08% <35.71%> (-0.89%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[github-actions]

E2E Tests Published Test Results

    2 files      2 suites   1h 35m 39s ⏱️
  95 tests   90 ✔️ 3 💤 2 ❌
192 runs  184 ✔️ 6 💤 2 ❌

For more details on these failures, see this check.

Results for commit 6aebcf2.

♻️ This comment has been updated with latest results.

[zachaller]

I think this is also maybe related: #1838

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
5.0% Duplication

[idurgakalyan]

@zachaller Are you able to review?

[idurgakalyan]

E2E tests failed due to empty value mismatch, Is there anything else that needs to be done?

[zachaller]

Yea I am just trying to decide which place is more appropriate to make this change I think this would also work #2540 it would still need a test case for it but yea. Would you mind letting me know if it also solves your issue?

[idurgakalyan]

@zachaller Yes, this would work.

[idurgakalyan]

I can close this PR once #2540 is merged.

[JAORMX]

you might want to propose this in a separate PR.

[zachaller]

closed by: #2540