Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix missing links for getting started documentation Fixes #2511 #2557

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

jiachengxu
Copy link
Member

@jiachengxu jiachengxu commented Feb 2, 2023

Signed-off-by: Jiacheng Xu [email protected]
Fixes: #2511

  • Getting started menu:

Screenshot 2023-02-03 at 01 25 57

  • Links at the bottom of the getting started page:

Screenshot 2023-02-03 at 01 27 05

Checklist:
  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@jiachengxu jiachengxu changed the title docs: fix missing links for getting started documentation docs: fix missing links for getting started documentation Fixes #2511 Feb 2, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

Go Published Test Results

1 834 tests   1 834 ✔️  2m 31s ⏱️
   105 suites         0 💤
       1 files           0

Results for commit c598f64.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

E2E Tests Published Test Results

    2 files      2 suites   1h 39m 3s ⏱️
  95 tests   90 ✔️ 3 💤 2
192 runs  184 ✔️ 6 💤 2

For more details on these failures, see this check.

Results for commit c598f64.

@jiachengxu
Copy link
Member Author

I don't think the failed test is related to this PR

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 81.66% // Head: 81.66% // No change to project coverage 👍

Coverage data is based on head (c598f64) compared to base (b60f69d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2557   +/-   ##
=======================================
  Coverage   81.66%   81.66%           
=======================================
  Files         126      126           
  Lines       19147    19147           
=======================================
  Hits        15636    15636           
  Misses       2717     2717           
  Partials      794      794           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zachaller zachaller merged commit 9c0785f into argoproj:master Feb 3, 2023
@zachaller
Copy link
Collaborator

Thank you for the contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting started documentation missing links
2 participants