Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add name attribute to ServicePort #2572

Merged
merged 9 commits into from
Feb 9, 2023
Merged

feat: Add name attribute to ServicePort #2572

merged 9 commits into from
Feb 9, 2023

Commits on Feb 7, 2023

  1. Add name attribute to ServicePort 

    Signed-off-by: Daniel Del Rio <[email protected]>
    @daniddelrio
    daniddelrio committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    6cd8202 View commit details
    Browse the repository at this point in the history

  2. Format with gofmt 

    Signed-off-by: Daniel Del Rio <[email protected]>
    @daniddelrio
    daniddelrio committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    9d1b667 View commit details
    Browse the repository at this point in the history

  3. Update experiment test by adding port name 

    Signed-off-by: Daniel Del Rio <[email protected]>
    @daniddelrio
    daniddelrio committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    ce7d56a View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. Include port name only when given 

    Signed-off-by: Daniel Del Rio <[email protected]>
    @daniddelrio
    daniddelrio committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    cd1c970 View commit details
    Browse the repository at this point in the history

  2. Implement separate e2e tests for single unnamed port and two named ports 

    Signed-off-by: Daniel Del Rio <[email protected]>
    @daniddelrio
    daniddelrio committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    1821988 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into named-experiment-ports

    @daniddelrio
    daniddelrio authored Feb 8, 2023
    Configuration menu
    Copy the full SHA
    eba9bf1 View commit details
    Browse the repository at this point in the history

  4. Remove port name in experiment_test.go 

    Signed-off-by: Daniel Del Rio <[email protected]>
    @daniddelrio
    daniddelrio committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    912ca6c View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. Merge branch 'master' into named-experiment-ports

    @daniddelrio
    daniddelrio authored Feb 9, 2023
    Configuration menu
    Copy the full SHA
    7b2a96a View commit details
    Browse the repository at this point in the history

  2. Replace Sleep in new multiport service experiment 

    Signed-off-by: Daniel Del Rio <[email protected]>
    @daniddelrio
    daniddelrio committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    96a9313 View commit details
    Browse the repository at this point in the history