Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change plugin naming pattern #2720 #2722

Merged
merged 1 commit into from
Apr 15, 2023

Conversation

meeech
Copy link
Contributor

@meeech meeech commented Apr 14, 2023

fixes #2720
Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • [n/a] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • [n/a] My organization is added to USERS.md.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2023

Go Published Test Results

1 948 tests   1 948 ✔️  2m 34s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit f7771ef.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4cecf34) 81.47% compared to head (f7771ef) 81.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2722   +/-   ##
=======================================
  Coverage   81.47%   81.47%           
=======================================
  Files         133      133           
  Lines       20154    20154           
=======================================
  Hits        16421    16421           
  Misses       2881     2881           
  Partials      852      852           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2023

E2E Tests Published Test Results

    4 files      4 suites   3h 43m 27s ⏱️
  96 tests   82 ✔️   5 💤   9
396 runs  365 ✔️ 20 💤 11

For more details on these failures, see this check.

Results for commit f7771ef.

♻️ This comment has been updated with latest results.

@meeech meeech force-pushed the change-plugin-naming-pattern-2720 branch from dfcbdb0 to 9379774 Compare April 14, 2023 12:50
@meeech meeech marked this pull request as ready for review April 15, 2023 02:09
* update contributor plugin guide
* update analysis/plugin overview
* update trafic-management/plugin overview
* automatic linting changes - whitespace, new line at end of file

Signed-off-by: mitchell amihod <[email protected]>

argoproj#2720
@meeech meeech force-pushed the change-plugin-naming-pattern-2720 branch from dc00d77 to f7771ef Compare April 15, 2023 02:12
@sonarcloud
Copy link

sonarcloud bot commented Apr 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zachaller zachaller merged commit c250c7e into argoproj:master Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the naming convention for plugins
2 participants